Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2315863002: Remove calls to deprecated MessageLoop methods in android_webview. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
michaelbai, boliu
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in android_webview. This CL (hopefully) removes all calls to these methods in android_webview: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=boliu@chromium.org Committed: https://crrev.com/ef08228e90549078a45a71c094edd9917640d1f1 Cr-Commit-Position: refs/heads/master@{#417069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M android_webview/browser/test/rendering_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/browser/test/rendering_test.cc View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 20:51:41 UTC) #4
michaelbai
Bo, would you like to take a look?
4 years, 3 months ago (2016-09-07 19:15:07 UTC) #10
boliu
lgtm
4 years, 3 months ago (2016-09-07 20:09:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315863002/1
4 years, 3 months ago (2016-09-07 20:17:11 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:59:41 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:02:47 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef08228e90549078a45a71c094edd9917640d1f1
Cr-Commit-Position: refs/heads/master@{#417069}

Powered by Google App Engine
This is Rietveld 408576698