Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenateTest.cpp

Issue 2315853002: Massively simplify WTF's StringConcatenate (Closed)
Patch Set: missing inlines. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringConcatenateTest.cpp
diff --git a/third_party/WebKit/Source/wtf/text/StringOperatorsTest.cpp b/third_party/WebKit/Source/wtf/text/StringConcatenateTest.cpp
similarity index 98%
rename from third_party/WebKit/Source/wtf/text/StringOperatorsTest.cpp
rename to third_party/WebKit/Source/wtf/text/StringConcatenateTest.cpp
index 788f21f5b0c94ed15eec79bcd28cc0d140102125..0893117493f539239c70198002de1ddc5a505f7a 100644
--- a/third_party/WebKit/Source/wtf/text/StringOperatorsTest.cpp
+++ b/third_party/WebKit/Source/wtf/text/StringConcatenateTest.cpp
@@ -35,12 +35,13 @@ namespace WTF {
#define EXPECT_N_WTF_STRING_COPIES(count, expr) \
do { \
wtfStringCopyCount = 0; \
- String __testString = expr; \
- (void)__testString; \
+ String testString = expr; \
+ (void)testString; \
EXPECT_EQ(count, wtfStringCopyCount) << #expr; \
} while (false)
-TEST(StringOperatorsTest, DISABLED_StringOperators)
+// TODO(esprehn): Fix or delete this test.
+TEST(StringConcatenateTest, DISABLED_StringCopies)
{
String string("String");
AtomicString atomicString("AtomicString");

Powered by Google App Engine
This is Rietveld 408576698