src/full-codegen/s390/full-codegen-s390.cc - Issue 2315733003: Class fields, part 1 (parsing and infrastructure)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/s390/full-codegen-s390.cc

Issue 2315733003: Class fields, part 1 (parsing and infrastructure) (Closed)

Patch Set: dan's comments pt2: tests Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/s390/full-codegen-s390.cc

diff --git a/src/full-codegen/s390/full-codegen-s390.cc b/src/full-codegen/s390/full-codegen-s390.cc

index 3cbcb7b9442aa122136556952b573953e8fa567b..016508e6c4faf3c063b53f07d46249093fa7dcc2 100644

--- a/src/full-codegen/s390/full-codegen-s390.cc

+++ b/src/full-codegen/s390/full-codegen-s390.cc

@@ -1989,6 +1989,7 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

CallRuntimeWithOperands(Runtime::kDefineSetterPropertyUnchecked);

break;

+ case ClassLiteral::Property::FIELD:

default:

UNREACHABLE();

}