src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2315733003: Class fields, part 1 (parsing and infrastructure)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2315733003: Class fields, part 1 (parsing and infrastructure) (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index f9711f372cc1c4173b2bb12b7d1426600adb65d9..81a952c788603f2446e5fe3714f9b51ba04c6cb2 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1934,6 +1934,10 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

PushOperand(Smi::FromInt(DONT_ENUM));

CallRuntimeWithOperands(Runtime::kDefineSetterPropertyUnchecked);

break;

+ case ClassLiteral::Property::FIELD:

+ UNREACHABLE();

+ break;

}