Revert of Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect

Revert of Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect (patchset #3 id:140001 of https://codereview.chromium.org/2297873002/ )

Reason for revert:
This makes Win Tests builder to hit the DCHECK, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/52416

Original issue's description:
> Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect
>
> The PaintLayer::backgroundIsKnownToBeOpaque method is currently
> only called by GraphicsLayers on their owning paint layer, or
> by the recursive child call. The former is by definition
> always called on a self painting layer, while the latter
> already has a test to prevent consideration of layers that
> do not paint into the backing in question. Hence we can
> remove the check for self painting layer status.
>
> Also convert a test for dirty stacking order lists to a
> DCHECK, because the test never fires on any layout test.
>
> These checks cause chicken-and-egg problems when the method
> is called by the layer itself in order to identify compositing
> reasons. In such cases we are not concerned with self layer
> status; we are in fact trying to determine that status.
>
> R=chrishtr@chromium.org
> BUG=381840
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/a879db6c440ffd9c296b1a3f272458212eac48b5
> Cr-Commit-Position: refs/heads/master@{#416628}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840
Committed: https://crrev.com/1551e13becc18ed64e3a67070f9679542adec01f
Cr-Commit-Position: refs/heads/master@{#416779}

[lushnikov, 2016-09-06 23:51:59]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-09-06 23:52:00]

Created Revert of Remove unnecessary checks in
PaintLayer::backgroundIsKnownToBeOpaqueInRect

[commit-bot: I haz the power, 2016-09-06 23:52:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 23:53:11]

Description was changed from

==========
Revert of Remove unnecessary checks in
PaintLayer::backgroundIsKnownToBeOpaqueInRect (patchset #3 id:140001 of
https://codereview.chromium.org/2297873002/ )

Reason for revert:
This makes Win Tests builder to hit the DCHECK, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...




Original issue's description:
> Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect
> 
> The PaintLayer::backgroundIsKnownToBeOpaque method is currently
> only called by GraphicsLayers on their owning paint layer, or
> by the recursive child call. The former is by definition
> always called on a self painting layer, while the latter
> already has a test to prevent consideration of layers that
> do not paint into the backing in question. Hence we can
> remove the check for self painting layer status.
> 
> Also convert a test for dirty stacking order lists to a
> DCHECK, because the test never fires on any layout test.
> 
> These checks cause chicken-and-egg problems when the method
> is called by the layer itself in order to identify compositing
> reasons. In such cases we are not concerned with self layer
> status; we are in fact trying to determine that status.
> 
> R=chrishtr@chromium.org
> BUG=381840
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/a879db6c440ffd9c296b1a3f272458212eac48b5
> Cr-Commit-Position: refs/heads/master@{#416628}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840
==========

to

==========
Revert of Remove unnecessary checks in
PaintLayer::backgroundIsKnownToBeOpaqueInRect (patchset #3 id:140001 of
https://codereview.chromium.org/2297873002/ )

Reason for revert:
This makes Win Tests builder to hit the DCHECK, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...




Original issue's description:
> Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect
> 
> The PaintLayer::backgroundIsKnownToBeOpaque method is currently
> only called by GraphicsLayers on their owning paint layer, or
> by the recursive child call. The former is by definition
> always called on a self painting layer, while the latter
> already has a test to prevent consideration of layers that
> do not paint into the backing in question. Hence we can
> remove the check for self painting layer status.
> 
> Also convert a test for dirty stacking order lists to a
> DCHECK, because the test never fires on any layout test.
> 
> These checks cause chicken-and-egg problems when the method
> is called by the layer itself in order to identify compositing
> reasons. In such cases we are not concerned with self layer
> status; we are in fact trying to determine that status.
> 
> R=chrishtr@chromium.org
> BUG=381840
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/a879db6c440ffd9c296b1a3f272458212eac48b5
> Cr-Commit-Position: refs/heads/master@{#416628}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840
==========

[commit-bot: I haz the power, 2016-09-06 23:53:12]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-06 23:55:15]

Description was changed from

==========
Revert of Remove unnecessary checks in
PaintLayer::backgroundIsKnownToBeOpaqueInRect (patchset #3 id:140001 of
https://codereview.chromium.org/2297873002/ )

Reason for revert:
This makes Win Tests builder to hit the DCHECK, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...




Original issue's description:
> Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect
> 
> The PaintLayer::backgroundIsKnownToBeOpaque method is currently
> only called by GraphicsLayers on their owning paint layer, or
> by the recursive child call. The former is by definition
> always called on a self painting layer, while the latter
> already has a test to prevent consideration of layers that
> do not paint into the backing in question. Hence we can
> remove the check for self painting layer status.
> 
> Also convert a test for dirty stacking order lists to a
> DCHECK, because the test never fires on any layout test.
> 
> These checks cause chicken-and-egg problems when the method
> is called by the layer itself in order to identify compositing
> reasons. In such cases we are not concerned with self layer
> status; we are in fact trying to determine that status.
> 
> R=chrishtr@chromium.org
> BUG=381840
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/a879db6c440ffd9c296b1a3f272458212eac48b5
> Cr-Commit-Position: refs/heads/master@{#416628}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840
==========

to

==========
Revert of Remove unnecessary checks in
PaintLayer::backgroundIsKnownToBeOpaqueInRect (patchset #3 id:140001 of
https://codereview.chromium.org/2297873002/ )

Reason for revert:
This makes Win Tests builder to hit the DCHECK, e.g.:

https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

Original issue's description:
> Remove unnecessary checks in PaintLayer::backgroundIsKnownToBeOpaqueInRect
>
> The PaintLayer::backgroundIsKnownToBeOpaque method is currently
> only called by GraphicsLayers on their owning paint layer, or
> by the recursive child call. The former is by definition
> always called on a self painting layer, while the latter
> already has a test to prevent consideration of layers that
> do not paint into the backing in question. Hence we can
> remove the check for self painting layer status.
>
> Also convert a test for dirty stacking order lists to a
> DCHECK, because the test never fires on any layout test.
>
> These checks cause chicken-and-egg problems when the method
> is called by the layer itself in order to identify compositing
> reasons. In such cases we are not concerned with self layer
> status; we are in fact trying to determine that status.
>
> R=chrishtr@chromium.org
> BUG=381840
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/a879db6c440ffd9c296b1a3f272458212eac48b5
> Cr-Commit-Position: refs/heads/master@{#416628}

TBR=chrishtr@chromium.org,schenney@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=381840

Committed: https://crrev.com/1551e13becc18ed64e3a67070f9679542adec01f
Cr-Commit-Position: refs/heads/master@{#416779}
==========

[commit-bot: I haz the power, 2016-09-06 23:55:16]

Patchset 1 (id:??) landed as
https://crrev.com/1551e13becc18ed64e3a67070f9679542adec01f
Cr-Commit-Position: refs/heads/master@{#416779}