scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json - Issue 2315653002: Do not start goma in ChromeOS gclient runhook if gomadir is given.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json

Issue 2315653002: Do not start goma in ChromeOS gclient runhook if gomadir is given. (Closed)

Patch Set: added a comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_daisy_Compile.json ('k') | scripts/slave/recipes/chromium_trybot.expected/chromeos_analyze.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json

diff --git a/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json b/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json

index b6b92ad92e5ba15d40a2a8c2f48b38e3e6a579f8..c4e1d1c12390e126f82d186536a1a40b28cdc9b9 100644

--- a/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json

+++ b/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json

@@ -189,6 +189,7 @@

"--clear-sdk-cache",

"--gomadir",

"[CACHE]/cipd/goma",

+ "--nostart-goma",

"--",

"python",

"-u",

@@ -261,6 +262,7 @@

"--clear-sdk-cache",

"--gomadir",

"[CACHE]/cipd/goma",

+ "--nostart-goma",

"--",

"python",

"-u",

@@ -291,6 +293,7 @@

"--use-external-config",

"--gomadir",

"[CACHE]/cipd/goma",

+ "--nostart-goma",

"--",

"python",

"-u",