Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json

Issue 2315653002: Do not start goma in ChromeOS gclient runhook if gomadir is given. (Closed)
Patch Set: fixed mistake not --goma-start but --nostart-goma. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 [ 1 [
2 { 2 {
3 "cmd": [ 3 "cmd": [
4 "python", 4 "python",
5 "-u", 5 "-u",
6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n", 6 "\nimport sys, os\npath = sys.argv[1]\nmode = int(sys.argv[2])\nif not os. path.isdir(path):\n if os.path.exists(path):\n print \"%s exists but is not a dir\" % path\n sys.exit(1)\n os.makedirs(path, mode)\n",
7 "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile", 7 "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile",
8 "511" 8 "511"
9 ], 9 ],
10 "name": "makedirs checkout path", 10 "name": "makedirs checkout path",
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 { 190 {
191 "cmd": [ 191 "cmd": [
192 "RECIPE_PACKAGE_REPO[depot_tools]/cros", 192 "RECIPE_PACKAGE_REPO[depot_tools]/cros",
193 "chrome-sdk", 193 "chrome-sdk",
194 "--board=amd64-generic", 194 "--board=amd64-generic",
195 "--nocolor", 195 "--nocolor",
196 "--use-external-config", 196 "--use-external-config",
197 "--clear-sdk-cache", 197 "--clear-sdk-cache",
198 "--gomadir", 198 "--gomadir",
199 "[CACHE]/cipd/goma", 199 "[CACHE]/cipd/goma",
200 "--nostart-goma",
200 "--", 201 "--",
201 "python", 202 "python",
202 "-u", 203 "-u",
203 "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py", 204 "RECIPE_PACKAGE_REPO[depot_tools]/gclient.py",
204 "runhooks" 205 "runhooks"
205 ], 206 ],
206 "cwd": "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile/src", 207 "cwd": "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile/src",
207 "env": { 208 "env": {
208 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json", 209 "GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account -goma-client.json",
209 "GYP_CHROMIUM_NO_ACTION": "1", 210 "GYP_CHROMIUM_NO_ACTION": "1",
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 { 263 {
263 "cmd": [ 264 "cmd": [
264 "RECIPE_PACKAGE_REPO[depot_tools]/cros", 265 "RECIPE_PACKAGE_REPO[depot_tools]/cros",
265 "chrome-sdk", 266 "chrome-sdk",
266 "--board=amd64-generic", 267 "--board=amd64-generic",
267 "--nocolor", 268 "--nocolor",
268 "--use-external-config", 269 "--use-external-config",
269 "--clear-sdk-cache", 270 "--clear-sdk-cache",
270 "--gomadir", 271 "--gomadir",
271 "[CACHE]/cipd/goma", 272 "[CACHE]/cipd/goma",
273 "--nostart-goma",
272 "--", 274 "--",
273 "python", 275 "python",
274 "-u", 276 "-u",
275 "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile/src/tools/mb/mb.py", 277 "[BUILDER_CACHE]/ChromiumOS_amd64_generic_Compile/src/tools/mb/mb.py",
276 "gen", 278 "gen",
277 "-m", 279 "-m",
278 "chromium.chromiumos", 280 "chromium.chromiumos",
279 "-b", 281 "-b",
280 "ChromiumOS amd64-generic Compile", 282 "ChromiumOS amd64-generic Compile",
281 "--config-file", 283 "--config-file",
(...skipping 10 matching lines...) Expand all
292 }, 294 },
293 { 295 {
294 "cmd": [ 296 "cmd": [
295 "RECIPE_PACKAGE_REPO[depot_tools]/cros", 297 "RECIPE_PACKAGE_REPO[depot_tools]/cros",
296 "chrome-sdk", 298 "chrome-sdk",
297 "--board=amd64-generic", 299 "--board=amd64-generic",
298 "--nocolor", 300 "--nocolor",
299 "--use-external-config", 301 "--use-external-config",
300 "--gomadir", 302 "--gomadir",
301 "[CACHE]/cipd/goma", 303 "[CACHE]/cipd/goma",
304 "--nostart-goma",
302 "--", 305 "--",
303 "python", 306 "python",
304 "-u", 307 "-u",
305 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py", 308 "RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",
306 "--show-path", 309 "--show-path",
307 "python", 310 "python",
308 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py", 311 "RECIPE_PACKAGE_REPO[build]/scripts/slave/compile.py",
309 "--gsutil-py-path", 312 "--gsutil-py-path",
310 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py", 313 "RECIPE_PACKAGE_REPO[depot_tools]/gsutil.py",
311 "--ninja-path", 314 "--ninja-path",
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \" build_data_dir\": \"[ROOT]/build_data_dir\", \"buildername\": \"ChromiumOS amd64 -generic Compile\", \"buildnumber\": 571, \"mastername\": \"chromium.chromiumos\ ", \"parent_buildername\": null, \"path_config\": \"kitchen\", \"recipe\": \"chr omium\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestS lavename\"}" 382 "{\"blamelist\": [\"cool_dev1337@chromium.org\", \"hax@chromium.org\"], \" build_data_dir\": \"[ROOT]/build_data_dir\", \"buildername\": \"ChromiumOS amd64 -generic Compile\", \"buildnumber\": 571, \"mastername\": \"chromium.chromiumos\ ", \"parent_buildername\": null, \"path_config\": \"kitchen\", \"recipe\": \"chr omium\", \"slavename\": \"TestSlavename\", \"workdir\": \"/path/to/workdir/TestS lavename\"}"
380 ], 383 ],
381 "name": "package build" 384 "name": "package build"
382 }, 385 },
383 { 386 {
384 "name": "$result", 387 "name": "$result",
385 "recipe_result": null, 388 "recipe_result": null,
386 "status_code": 0 389 "status_code": 0
387 } 390 }
388 ] 391 ]
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698