Do not start goma in ChromeOS gclient runhook if gomadir is given.

scripts/slave/recipe_modules/chromium/api.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from recipe_engine import recipe_api
 from recipe_engine import util as recipe_util
 
 class TestLauncherFilterFileInputPlaceholder(recipe_util.InputPlaceholder):
@@ skipping 456 matching lines @@
         self.m.depot_tools.cros_path, 'chrome-sdk',
         '--board=%s' % (self.c.TARGET_CROS_BOARD,),
         '--nocolor',]
     wrapper += self.c.cros_sdk.args
     if self.c.cros_sdk.external:
       wrapper += ['--use-external-config']
     if clean:
       wrapper += ['--clear-sdk-cache']
     if self.c.compile_py.goma_dir:
       wrapper += ['--gomadir', self.c.compile_py.goma_dir]
+      wrapper += ['--nostart-goma']

[dnj, 2016/09/08 16:14:45]

Can you add a comment here detailing why this flag is added? The "--gomadir" one
is obvious, but "--nostart-goma" is a little less so.

As an aside, why don't we just make it so that "chrome-sdk" is smart enough to
not start goma when "--gomadir" is provided? Is there ever a situation where
"--gomadir" will be supplied and we actually want it to start Goma? From this CL
description, it sounds like the answer is, "no".

[Yoshisato Yanagisawa, 2016/09/12 01:55:11]

Wrote a comment.

I do not know a situation where "--gomadir" is supplied and we actually want it
start goma.  However, I am not confident to say no.
Then, it comes to me the question, "Is it natural to skip starting goma if
--gomadir is set?"  I can hardly say yes.  It looks like the flag to mention
which goma directory to use but it might not look like a flag to change anything
else.  Let me make the script have --nostart-goma.

     if self.c.gyp_env.GYP_DEFINES.get('fastbuild', 0) == 1:
       wrapper += ['--fastbuild']
     wrapper += ['--']
     return wrapper
 
   def ensure_goma(self, canary=False):
     goma_dir = self.m.goma.ensure_goma(canary=canary)
     if goma_dir:
       # TODO(phajdan.jr): goma_dir should always be non-empty.
       self.c.gyp_env.GYP_DEFINES['gomadir'] = goma_dir
@@ skipping 315 matching lines @@
       }))
 
   def get_annotate_by_test_name(self, test_name):
     return 'graphing'
 
   def download_lto_plugin(self):
     return self.m.python(
         name='download LTO plugin',
         script=self.m.path['checkout'].join(
             'build', 'download_gold_plugin.py'))