Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: net/socket/client_socket_handle.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Ran "git cl format" on code. Much formatting ensued. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/sdch/sdch_owner.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket/client_socket_handle.cc
diff --git a/net/socket/client_socket_handle.cc b/net/socket/client_socket_handle.cc
index 77026d5af2fdfb13b639bb1f1ee5240fd897e7a6..f171552e4c291b41dceb085a1e0a7286cbc34bed 100644
--- a/net/socket/client_socket_handle.cc
+++ b/net/socket/client_socket_handle.cc
@@ -12,6 +12,7 @@
#include "base/logging.h"
#include "base/trace_event/trace_event.h"
#include "net/base/net_errors.h"
+#include "net/log/net_log_event_type.h"
#include "net/socket/client_socket_pool.h"
namespace net {
@@ -41,7 +42,7 @@ void ClientSocketHandle::ResetInternal(bool cancel) {
CHECK(pool_);
if (is_initialized()) {
if (socket_) {
- socket_->NetLog().EndEvent(NetLog::TYPE_SOCKET_IN_USE);
+ socket_->NetLog().EndEvent(NetLogEventType::SOCKET_IN_USE);
// Release the socket back to the ClientSocketPool so it can be
// deleted or reused.
pool_->ReleaseSocket(group_name_, std::move(socket_), pool_id_);
@@ -167,9 +168,8 @@ void ClientSocketHandle::HandleInitCompletion(int result) {
// release() socket. It ends up working though, since those methods are being
// used to layer sockets (and the destination sources are the same).
DCHECK(socket_.get());
- socket_->NetLog().BeginEvent(
- NetLog::TYPE_SOCKET_IN_USE,
- requesting_source_.ToEventParametersCallback());
+ socket_->NetLog().BeginEvent(NetLogEventType::SOCKET_IN_USE,
+ requesting_source_.ToEventParametersCallback());
}
} // namespace net
« no previous file with comments | « net/sdch/sdch_owner.cc ('k') | net/socket/client_socket_pool_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698