Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: net/proxy/proxy_resolver_v8_tracing_wrapper.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Ran "git cl format" on code. Much formatting ensued. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_v8_tracing_wrapper.cc
diff --git a/net/proxy/proxy_resolver_v8_tracing_wrapper.cc b/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
index 8c23cab5e25e2957de917c5498c0c48aa216d17a..a368ebfd16a74ca64d29ebcc8641741df945d04f 100644
--- a/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
+++ b/net/proxy/proxy_resolver_v8_tracing_wrapper.cc
@@ -13,6 +13,7 @@
#include "base/values.h"
#include "net/base/net_errors.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_event_type.h"
#include "net/proxy/proxy_resolver_error_observer.h"
namespace net {
@@ -44,14 +45,14 @@ class BindingsImpl : public ProxyResolverV8Tracing::Bindings {
void Alert(const base::string16& message) override {
// Send to the NetLog.
LogEventToCurrentRequestAndGlobally(
- NetLog::TYPE_PAC_JAVASCRIPT_ALERT,
+ NetLogEventType::PAC_JAVASCRIPT_ALERT,
NetLog::StringCallback("message", &message));
}
void OnError(int line_number, const base::string16& message) override {
// Send the error to the NetLog.
LogEventToCurrentRequestAndGlobally(
- NetLog::TYPE_PAC_JAVASCRIPT_ERROR,
+ NetLogEventType::PAC_JAVASCRIPT_ERROR,
base::Bind(&NetLogErrorCallback, line_number, &message));
if (error_observer_)
error_observer_->OnPACScriptError(line_number, message);
@@ -63,7 +64,7 @@ class BindingsImpl : public ProxyResolverV8Tracing::Bindings {
private:
void LogEventToCurrentRequestAndGlobally(
- NetLog::EventType type,
+ NetLogEventType type,
const NetLog::ParametersCallback& parameters_callback) {
bound_net_log_.AddEvent(type, parameters_callback);
« no previous file with comments | « net/proxy/proxy_resolver_factory_mojo_unittest.cc ('k') | net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698