Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1596)

Unified Diff: net/log/write_to_file_net_log_observer_unittest.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Ran "git cl format" on code. Much formatting ensued. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/log/trace_net_log_observer_unittest.cc ('k') | net/proxy/multi_threaded_proxy_resolver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/log/write_to_file_net_log_observer_unittest.cc
diff --git a/net/log/write_to_file_net_log_observer_unittest.cc b/net/log/write_to_file_net_log_observer_unittest.cc
index c1ab52f36f3ce9e42e0fa5d072c51f6ded074d64..67f410abffce9ee2a8f76b762953568ab6a01b2a 100644
--- a/net/log/write_to_file_net_log_observer_unittest.cc
+++ b/net/log/write_to_file_net_log_observer_unittest.cc
@@ -14,6 +14,8 @@
#include "base/json/json_reader.h"
#include "base/values.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_source_type.h"
#include "net/log/net_log_util.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_context.h"
@@ -89,9 +91,9 @@ TEST_F(WriteToFileNetLogObserverTest, GeneratesValidJSONWithOneEvent) {
logger->StartObserving(&net_log_, std::move(file), nullptr, nullptr);
const int kDummyId = 1;
- NetLog::Source source(NetLog::SOURCE_HTTP2_SESSION, kDummyId);
- NetLog::EntryData entry_data(NetLog::TYPE_PROXY_SERVICE, source,
- NetLog::PHASE_BEGIN, base::TimeTicks::Now(),
+ NetLog::Source source(NetLogSourceType::HTTP2_SESSION, kDummyId);
+ NetLog::EntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
+ NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
NULL);
NetLog::Entry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
logger->OnAddEntry(entry);
@@ -120,9 +122,9 @@ TEST_F(WriteToFileNetLogObserverTest, GeneratesValidJSONWithMultipleEvents) {
logger->StartObserving(&net_log_, std::move(file), nullptr, nullptr);
const int kDummyId = 1;
- NetLog::Source source(NetLog::SOURCE_HTTP2_SESSION, kDummyId);
- NetLog::EntryData entry_data(NetLog::TYPE_PROXY_SERVICE, source,
- NetLog::PHASE_BEGIN, base::TimeTicks::Now(),
+ NetLog::Source source(NetLogSourceType::HTTP2_SESSION, kDummyId);
+ NetLog::EntryData entry_data(NetLogEventType::PROXY_SERVICE, source,
+ NetLogEventPhase::BEGIN, base::TimeTicks::Now(),
NULL);
NetLog::Entry entry(&entry_data, NetLogCaptureMode::IncludeSocketBytes());
« no previous file with comments | « net/log/trace_net_log_observer_unittest.cc ('k') | net/proxy/multi_threaded_proxy_resolver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698