Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: content/browser/appcache/appcache_url_request_job.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Ran "git cl format" on code. Much formatting ensued. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/net_log/net_log_file_writer_unittest.cc ('k') | content/browser/download/base_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_url_request_job.cc
diff --git a/content/browser/appcache/appcache_url_request_job.cc b/content/browser/appcache/appcache_url_request_job.cc
index 58fededa02293b6461961b6c3854500d8ee1f10d..1bfd99a7ef275413da7f64311b59175ed4aab99f 100644
--- a/content/browser/appcache/appcache_url_request_job.cc
+++ b/content/browser/appcache/appcache_url_request_job.cc
@@ -26,6 +26,7 @@
#include "net/http/http_response_headers.h"
#include "net/http/http_util.h"
#include "net/log/net_log.h"
+#include "net/log/net_log_event_type.h"
#include "net/url_request/url_request.h"
#include "net/url_request/url_request_status.h"
@@ -121,7 +122,7 @@ void AppCacheURLRequestJob::BeginDelivery() {
AppCacheHistograms::AddErrorJobStartDelaySample(
base::TimeTicks::Now() - start_time_tick_);
request()->net_log().AddEvent(
- net::NetLog::TYPE_APPCACHE_DELIVERING_ERROR_RESPONSE);
+ net::NetLogEventType::APPCACHE_DELIVERING_ERROR_RESPONSE);
NotifyStartError(net::URLRequestStatus(net::URLRequestStatus::FAILED,
net::ERR_FAILED));
break;
@@ -134,9 +135,9 @@ void AppCacheURLRequestJob::BeginDelivery() {
AppCacheHistograms::AddAppCacheJobStartDelaySample(
base::TimeTicks::Now() - start_time_tick_);
request()->net_log().AddEvent(
- is_fallback_ ?
- net::NetLog::TYPE_APPCACHE_DELIVERING_FALLBACK_RESPONSE :
- net::NetLog::TYPE_APPCACHE_DELIVERING_CACHED_RESPONSE);
+ is_fallback_
+ ? net::NetLogEventType::APPCACHE_DELIVERING_FALLBACK_RESPONSE
+ : net::NetLogEventType::APPCACHE_DELIVERING_CACHED_RESPONSE);
storage_->LoadResponseInfo(manifest_url_, entry_.response_id(), this);
break;
@@ -155,7 +156,7 @@ void AppCacheURLRequestJob::BeginExecutableHandlerDelivery() {
}
request()->net_log().AddEvent(
- net::NetLog::TYPE_APPCACHE_DELIVERING_EXECUTABLE_RESPONSE);
+ net::NetLogEventType::APPCACHE_DELIVERING_EXECUTABLE_RESPONSE);
// We defer job delivery until the executable handler is spun up and
// provides a response. The sequence goes like this...
« no previous file with comments | « components/net_log/net_log_file_writer_unittest.cc ('k') | content/browser/download/base_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698