net/spdy/spdy_http_stream.cc - Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_http_stream.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)

Patch Set: Fixed a straggling, old enum and applied static_cast<int> to the new netlog enum types, since this … Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_http_stream.cc

diff --git a/net/spdy/spdy_http_stream.cc b/net/spdy/spdy_http_stream.cc

index 31b033aea06f0c30fbf0baaee878fd7732b11c13..01656e93cc912679f174bbe98428388fca410ec5 100644

--- a/net/spdy/spdy_http_stream.cc

+++ b/net/spdy/spdy_http_stream.cc

@@ -22,6 +22,7 @@

#include "net/http/http_request_info.h"

#include "net/http/http_response_info.h"

#include "net/log/net_log.h"

+#include "net/log/net_log_event_type.h"

#include "net/spdy/spdy_header_block.h"

#include "net/spdy/spdy_http_utils.h"

#include "net/spdy/spdy_protocol.h"

@@ -280,7 +281,7 @@ int SpdyHttpStream::SendRequest(const HttpRequestHeaders& request_headers,

CreateSpdyHeadersFromHttpRequest(*request_info_, request_headers, direct_,

&headers);

stream_->net_log().AddEvent(

- NetLog::TYPE_HTTP_TRANSACTION_HTTP2_SEND_REQUEST_HEADERS,

+ NetLogEventType::HTTP_TRANSACTION_HTTP2_SEND_REQUEST_HEADERS,

base::Bind(&SpdyHeaderBlockNetLogCallback, &headers));

result = stream_->SendRequestHeaders(

std::move(headers),