net/log/net_log_event_type_list.h - Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/log/net_log_event_type_list.h

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/log/net_log_event_type_list.h

diff --git a/net/log/net_log_event_type_list.h b/net/log/net_log_event_type_list.h

index 833e421f022c68c3c9d08de0d8d34b18b03bd37f..f0d43fff931eb22fcdde38bf927e630020ef2bda 100644

--- a/net/log/net_log_event_type_list.h

+++ b/net/log/net_log_event_type_list.h

@@ -475,7 +475,7 @@ EVENT_TYPE(SSL_CLIENT_CERT_REQUESTED)

// "type": <type of the key>,

// "hash": <hash function used>,

// }

-EVENT_TYPE(SSL_PRIVATE_KEY_OPERATION)

+EVENT_TYPE(SSL_PRIVATE_KEY_OP)

eroman 2016/09/06 19:32:20 Why this change? I am assuming this is to prevent

mikecirone 2016/09/07 21:35:41 Yes, it prevents macro collision with OpenSSL.

// The start/end of getting a domain-bound certificate and private key.