Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: net/disk_cache/memory/mem_entry_impl.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/memory/mem_entry_impl.cc
diff --git a/net/disk_cache/memory/mem_entry_impl.cc b/net/disk_cache/memory/mem_entry_impl.cc
index f1efa334af412d9aa0142087f8edb453d42a62d1..1574fbb364e0bad787df6b62df653ce6c8d1a0b1 100644
--- a/net/disk_cache/memory/mem_entry_impl.cc
+++ b/net/disk_cache/memory/mem_entry_impl.cc
@@ -15,6 +15,8 @@
#include "net/base/net_errors.h"
#include "net/disk_cache/memory/mem_backend_impl.h"
#include "net/disk_cache/net_log_parameters.h"
+#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_source_type.h"
using base::Time;
@@ -129,7 +131,7 @@ void MemEntryImpl::Doom() {
if (!doomed_) {
doomed_ = true;
backend_->OnEntryDoomed(this);
- net_log_.AddEvent(net::NetLog::TYPE_ENTRY_DOOM);
+ net_log_.AddEvent(net::NetLogEventType::ENTRY_DOOM);
}
if (!ref_count_)
delete this;
@@ -167,7 +169,7 @@ int MemEntryImpl::ReadData(int index, int offset, IOBuffer* buf, int buf_len,
const CompletionCallback& callback) {
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_ENTRY_READ_DATA,
+ net::NetLogEventType::ENTRY_READ_DATA,
CreateNetLogReadWriteDataCallback(index, offset, buf_len, false));
}
@@ -175,7 +177,7 @@ int MemEntryImpl::ReadData(int index, int offset, IOBuffer* buf, int buf_len,
if (net_log_.IsCapturing()) {
net_log_.EndEvent(
- net::NetLog::TYPE_ENTRY_READ_DATA,
+ net::NetLogEventType::ENTRY_READ_DATA,
CreateNetLogReadWriteCompleteCallback(result));
}
return result;
@@ -185,7 +187,7 @@ int MemEntryImpl::WriteData(int index, int offset, IOBuffer* buf, int buf_len,
const CompletionCallback& callback, bool truncate) {
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_ENTRY_WRITE_DATA,
+ net::NetLogEventType::ENTRY_WRITE_DATA,
CreateNetLogReadWriteDataCallback(index, offset, buf_len, truncate));
}
@@ -193,7 +195,7 @@ int MemEntryImpl::WriteData(int index, int offset, IOBuffer* buf, int buf_len,
if (net_log_.IsCapturing()) {
net_log_.EndEvent(
- net::NetLog::TYPE_ENTRY_WRITE_DATA,
+ net::NetLogEventType::ENTRY_WRITE_DATA,
CreateNetLogReadWriteCompleteCallback(result));
}
return result;
@@ -205,12 +207,12 @@ int MemEntryImpl::ReadSparseData(int64_t offset,
const CompletionCallback& callback) {
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_SPARSE_READ,
+ net::NetLogEventType::SPARSE_READ,
CreateNetLogSparseOperationCallback(offset, buf_len));
}
int result = InternalReadSparseData(offset, buf, buf_len);
if (net_log_.IsCapturing())
- net_log_.EndEvent(net::NetLog::TYPE_SPARSE_READ);
+ net_log_.EndEvent(net::NetLogEventType::SPARSE_READ);
return result;
}
@@ -220,12 +222,12 @@ int MemEntryImpl::WriteSparseData(int64_t offset,
const CompletionCallback& callback) {
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_SPARSE_WRITE,
+ net::NetLogEventType::SPARSE_WRITE,
CreateNetLogSparseOperationCallback(offset, buf_len));
}
int result = InternalWriteSparseData(offset, buf, buf_len);
if (net_log_.IsCapturing())
- net_log_.EndEvent(net::NetLog::TYPE_SPARSE_WRITE);
+ net_log_.EndEvent(net::NetLogEventType::SPARSE_WRITE);
return result;
}
@@ -235,13 +237,13 @@ int MemEntryImpl::GetAvailableRange(int64_t offset,
const CompletionCallback& callback) {
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_SPARSE_GET_RANGE,
+ net::NetLogEventType::SPARSE_GET_RANGE,
CreateNetLogSparseOperationCallback(offset, len));
}
int result = InternalGetAvailableRange(offset, len, start);
if (net_log_.IsCapturing()) {
net_log_.EndEvent(
- net::NetLog::TYPE_SPARSE_GET_RANGE,
+ net::NetLogEventType::SPARSE_GET_RANGE,
CreateNetLogGetAvailableRangeResultCallback(*start, result));
}
return result;
@@ -274,8 +276,9 @@ MemEntryImpl::MemEntryImpl(MemBackendImpl* backend,
doomed_(false) {
backend_->OnEntryInserted(this);
net_log_ =
- net::BoundNetLog::Make(net_log, net::NetLog::SOURCE_MEMORY_CACHE_ENTRY);
- net_log_.BeginEvent(net::NetLog::TYPE_DISK_CACHE_MEM_ENTRY_IMPL,
+ net::BoundNetLog::Make(
+ net_log, net::NetLogSourceType::MEMORY_CACHE_ENTRY);
+ net_log_.BeginEvent(net::NetLogEventType::DISK_CACHE_MEM_ENTRY_IMPL,
base::Bind(&NetLogEntryCreationCallback, this));
}
@@ -297,7 +300,7 @@ MemEntryImpl::~MemEntryImpl() {
} else {
parent_->children_->erase(child_id_);
}
- net_log_.EndEvent(net::NetLog::TYPE_DISK_CACHE_MEM_ENTRY_IMPL);
+ net_log_.EndEvent(net::NetLogEventType::DISK_CACHE_MEM_ENTRY_IMPL);
}
int MemEntryImpl::InternalReadData(int index, int offset, IOBuffer* buf,
@@ -392,7 +395,7 @@ int MemEntryImpl::InternalReadSparseData(int64_t offset,
break;
if (net_log_.IsCapturing()) {
net_log_.BeginEvent(
- net::NetLog::TYPE_SPARSE_READ_CHILD_DATA,
+ net::NetLogEventType::SPARSE_READ_CHILD_DATA,
CreateNetLogSparseReadWriteCallback(child->net_log_.source(),
io_buf->BytesRemaining()));
}
@@ -400,7 +403,7 @@ int MemEntryImpl::InternalReadSparseData(int64_t offset,
io_buf->BytesRemaining(), CompletionCallback());
if (net_log_.IsCapturing()) {
net_log_.EndEventWithNetErrorCode(
- net::NetLog::TYPE_SPARSE_READ_CHILD_DATA, ret);
+ net::NetLogEventType::SPARSE_READ_CHILD_DATA, ret);
}
// If we encounter an error in one entry, return immediately.
@@ -448,7 +451,7 @@ int MemEntryImpl::InternalWriteSparseData(int64_t offset,
int data_size = child->GetDataSize(kSparseData);
if (net_log_.IsCapturing()) {
- net_log_.BeginEvent(net::NetLog::TYPE_SPARSE_WRITE_CHILD_DATA,
+ net_log_.BeginEvent(net::NetLogEventType::SPARSE_WRITE_CHILD_DATA,
CreateNetLogSparseReadWriteCallback(
child->net_log_.source(), write_len));
}
@@ -461,7 +464,7 @@ int MemEntryImpl::InternalWriteSparseData(int64_t offset,
write_len, CompletionCallback(), true);
if (net_log_.IsCapturing()) {
net_log_.EndEventWithNetErrorCode(
- net::NetLog::TYPE_SPARSE_WRITE_CHILD_DATA, ret);
+ net::NetLogEventType::SPARSE_WRITE_CHILD_DATA, ret);
}
if (ret < 0)
return ret;

Powered by Google App Engine
This is Rietveld 408576698