Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: content/browser/download/download_file_impl.cc

Issue 2315613002: Extracted NetLog class's inner enum types into their own enum classes and (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_impl.cc
diff --git a/content/browser/download/download_file_impl.cc b/content/browser/download/download_file_impl.cc
index 086c1e4d5271c02d00b0362d8d36631dde19830b..2e6c7a75ae377ad7fd1421c6a6a60e4b1ea13b82 100644
--- a/content/browser/download/download_file_impl.cc
+++ b/content/browser/download/download_file_impl.cc
@@ -22,6 +22,8 @@
#include "crypto/secure_hash.h"
#include "crypto/sha2.h"
#include "net/base/io_buffer.h"
+#include "net/log/net_log_event_type.h"
+#include "net/log/net_log_source_type.h"
namespace content {
@@ -43,7 +45,7 @@ DownloadFileImpl::DownloadFileImpl(
const net::BoundNetLog& download_item_net_log,
base::WeakPtr<DownloadDestinationObserver> observer)
: bound_net_log_(net::BoundNetLog::Make(download_item_net_log.net_log(),
- net::NetLog::SOURCE_DOWNLOAD_FILE)),
+ net::NetLogSourceType::DOWNLOAD_FILE)),
file_(bound_net_log_),
save_info_(std::move(save_info)),
default_download_directory_(default_download_directory),
@@ -52,16 +54,16 @@ DownloadFileImpl::DownloadFileImpl(
observer_(observer),
weak_factory_(this) {
download_item_net_log.AddEvent(
- net::NetLog::TYPE_DOWNLOAD_FILE_CREATED,
+ net::NetLogEventType::DOWNLOAD_FILE_CREATED,
bound_net_log_.source().ToEventParametersCallback());
bound_net_log_.BeginEvent(
- net::NetLog::TYPE_DOWNLOAD_FILE_ACTIVE,
+ net::NetLogEventType::DOWNLOAD_FILE_ACTIVE,
download_item_net_log.source().ToEventParametersCallback());
}
DownloadFileImpl::~DownloadFileImpl() {
DCHECK_CURRENTLY_ON(BrowserThread::FILE);
- bound_net_log_.EndEvent(net::NetLog::TYPE_DOWNLOAD_FILE_ACTIVE);
+ bound_net_log_.EndEvent(net::NetLogEventType::DOWNLOAD_FILE_ACTIVE);
}
void DownloadFileImpl::Initialize(const InitializeCallback& callback) {
@@ -333,7 +335,7 @@ void DownloadFileImpl::StreamActive() {
}
if (bound_net_log_.IsCapturing()) {
bound_net_log_.AddEvent(
- net::NetLog::TYPE_DOWNLOAD_STREAM_DRAINED,
+ net::NetLogEventType::DOWNLOAD_STREAM_DRAINED,
base::Bind(&FileStreamDrainedNetLogCallback, total_incoming_data_size,
num_buffers));
}

Powered by Google App Engine
This is Rietveld 408576698