Extracted NetLog class's inner enum types into their own enum classes and

net/base/logging_network_change_observer.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/logging_network_change_observer.h"
 
 #include <string>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 #include "net/log/net_log.h"
+#include "net/log/net_log_event_type.h"
 
 #if defined(OS_ANDROID)
 #include "base/android/build_info.h"
 #endif
 
 namespace net {
 
 namespace {
 
 // Returns a human readable integer from a NetworkHandle.
@@ skipping 53 matching lines @@
   NetworkChangeNotifier::RemoveIPAddressObserver(this);
   NetworkChangeNotifier::RemoveConnectionTypeObserver(this);
   NetworkChangeNotifier::RemoveNetworkChangeObserver(this);
   if (NetworkChangeNotifier::AreNetworkHandlesSupported())
     NetworkChangeNotifier::RemoveNetworkObserver(this);
 }
 
 void LoggingNetworkChangeObserver::OnIPAddressChanged() {
   VLOG(1) << "Observed a change to the network IP addresses";
 
-  net_log_->AddGlobalEntry(NetLog::TYPE_NETWORK_IP_ADDRESSES_CHANGED);
+  net_log_->AddGlobalEntry(NetLogEventType::NETWORK_IP_ADDRESSES_CHANGED);
 }
 
 void LoggingNetworkChangeObserver::OnConnectionTypeChanged(
     NetworkChangeNotifier::ConnectionType type) {
   std::string type_as_string =
       NetworkChangeNotifier::ConnectionTypeToString(type);
 
   VLOG(1) << "Observed a change to network connectivity state "
           << type_as_string;
 
   net_log_->AddGlobalEntry(
-      NetLog::TYPE_NETWORK_CONNECTIVITY_CHANGED,
+      NetLogEventType::NETWORK_CONNECTIVITY_CHANGED,
       NetLog::StringCallback("new_connection_type", &type_as_string));
 }
 
 void LoggingNetworkChangeObserver::OnNetworkChanged(
     NetworkChangeNotifier::ConnectionType type) {
   std::string type_as_string =
       NetworkChangeNotifier::ConnectionTypeToString(type);
 
   VLOG(1) << "Observed a network change to state " << type_as_string;
 
   net_log_->AddGlobalEntry(
-      NetLog::TYPE_NETWORK_CHANGED,
+      NetLogEventType::NETWORK_CHANGED,
       NetLog::StringCallback("new_connection_type", &type_as_string));
 }
 
 void LoggingNetworkChangeObserver::OnNetworkConnected(
     NetworkChangeNotifier::NetworkHandle network) {
   VLOG(1) << "Observed network " << network << " connect";
 
-  net_log_->AddGlobalEntry(NetLog::TYPE_SPECIFIC_NETWORK_CONNECTED,
+  net_log_->AddGlobalEntry(NetLogEventType::SPECIFIC_NETWORK_CONNECTED,
                            base::Bind(&NetworkSpecificNetLogCallback, network));
 }
 
 void LoggingNetworkChangeObserver::OnNetworkDisconnected(
     NetworkChangeNotifier::NetworkHandle network) {
   VLOG(1) << "Observed network " << network << " disconnect";
 
-  net_log_->AddGlobalEntry(NetLog::TYPE_SPECIFIC_NETWORK_DISCONNECTED,
+  net_log_->AddGlobalEntry(NetLogEventType::SPECIFIC_NETWORK_DISCONNECTED,
                            base::Bind(&NetworkSpecificNetLogCallback, network));
 }
 
 void LoggingNetworkChangeObserver::OnNetworkSoonToDisconnect(
     NetworkChangeNotifier::NetworkHandle network) {
   VLOG(1) << "Observed network " << network << " soon to disconnect";
 
-  net_log_->AddGlobalEntry(NetLog::TYPE_SPECIFIC_NETWORK_SOON_TO_DISCONNECT,
+  net_log_->AddGlobalEntry(NetLogEventType::SPECIFIC_NETWORK_SOON_TO_DISCONNECT,
                            base::Bind(&NetworkSpecificNetLogCallback, network));
 }
 
 void LoggingNetworkChangeObserver::OnNetworkMadeDefault(
     NetworkChangeNotifier::NetworkHandle network) {
   VLOG(1) << "Observed network " << network << " made the default network";
 
-  net_log_->AddGlobalEntry(NetLog::TYPE_SPECIFIC_NETWORK_MADE_DEFAULT,
+  net_log_->AddGlobalEntry(NetLogEventType::SPECIFIC_NETWORK_MADE_DEFAULT,
                            base::Bind(&NetworkSpecificNetLogCallback, network));
 }
 
 }  // namespace net