Reset popup dismissal timers when replacing a notification.

Reset popup dismissal timers when replacing a notification.

Replacing a notification should reset the popup dismissal timer. Right
now the timer of the original notification continues to run, which means
that a popup might disappear immediately after being updated.

Also removes some methods that were tested, but not used.

BUG=

Committed: https://crrev.com/90faa187809eb5f2bf37d20052f5787633e9223b
Cr-Commit-Position: refs/heads/master@{#417993}

[Peter Beverloo, 2016-09-05 16:44:26]

Patchset #1 (id:1) has been deleted

[Peter Beverloo, 2016-09-05 16:44:29]

The CQ bit was checked by peter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 16:44:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Beverloo, 2016-09-05 16:46:09]

peter@chromium.org changed reviewers:
+ dewittj@chromium.org

[Peter Beverloo, 2016-09-05 16:46:09]

Hi Justin, WDYT?

Web Notifications will soon[1] begin to use native replacement as they'll
get consistent IDs, which triggered this bug in my testing. Was it decided
that replacing a notification should *not* reset the timer previously?

[1] https://codereview.chromium.org/2300093002

[commit-bot: I haz the power, 2016-09-05 17:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 17:41:39]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2016-09-08 13:28:38]

peter@chromium.org changed reviewers:
+ stevenjb@chromium.org

[Peter Beverloo, 2016-09-08 13:28:38]

+stevenjb, who was involved in previous reviews for this code

[dewittj, 2016-09-08 17:08:30]

Sorry for the delay!

I think we indeed made it so that updating didn't reset the timer intentionally.
 The worry back then was about notification spam updating to keep itself on
screen forever.  Now that there is a bit to do that, there isn't really any
concern anymore.

[Peter Beverloo, 2016-09-08 18:29:46]

On 2016/09/08 17:08:30, dewittj wrote:
> Sorry for the delay!
> 
> I think we indeed made it so that updating didn't reset the timer
intentionally.
>  The worry back then was about notification spam updating to keep itself on
> screen forever.  Now that there is a bit to do that, there isn't really any
> concern anymore.

I indeed hadn't considered that case. As you say, we now support
`requireInteraction` for both Web Notifications and Extension Notifications.
(We're even going through significant lengths to make this work with Windows and
Mac system notification centers.)

Could you review this CL, or would you prefer Steven or somebody else to take a
look?

[Peter Beverloo, 2016-09-12 14:49:49]

Friendly ping :).

[stevenjb, 2016-09-12 15:12:37]

I haven't been in this code in a very long while, I would defer to dewittj@.

[Miguel Garcia, 2016-09-12 16:28:17]

miguelg@chromium.org changed reviewers:
+ miguelg@chromium.org

[Miguel Garcia, 2016-09-12 16:28:18]

(non owner) lgtm

I would have vouched to split the removal of dead code and the addition of new
logic in two CLs but it's fairly small so it seems ok.

[dewittj, 2016-09-12 17:55:49]

lgtm, sorry for the delays.

[Peter Beverloo, 2016-09-12 18:08:09]

Thank you!! :)

[Peter Beverloo, 2016-09-12 18:08:19]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2016-09-12 18:08:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 19:09:07]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-12 19:11:25]

Description was changed from

==========
Reset popup dismissal timers when replacing a notification.

Replacing a notification should reset the popup dismissal timer. Right
now the timer of the original notification continues to run, which means
that a popup might disappear immediately after being updated.

Also removes some methods that were tested, but not used.

BUG=
==========

to

==========
Reset popup dismissal timers when replacing a notification.

Replacing a notification should reset the popup dismissal timer. Right
now the timer of the original notification continues to run, which means
that a popup might disappear immediately after being updated.

Also removes some methods that were tested, but not used.

BUG=

Committed: https://crrev.com/90faa187809eb5f2bf37d20052f5787633e9223b
Cr-Commit-Position: refs/heads/master@{#417993}
==========

[commit-bot: I haz the power, 2016-09-12 19:11:27]

Patchset 1 (id:??) landed as
https://crrev.com/90faa187809eb5f2bf37d20052f5787633e9223b
Cr-Commit-Position: refs/heads/master@{#417993}