Implement ToValue() for SystemMetrics, SystemMemoryInfoKB, DiskInfo, and SwapInfo.

base/process/process_metrics.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains routines for gathering resource statistics for processes
 // running on the system.
 
 #ifndef BASE_PROCESS_PROCESS_METRICS_H_
 #define BASE_PROCESS_PROCESS_METRICS_H_
 
 #include <string>
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/process/process_handle.h"
 #include "base/time/time.h"
+#include "base/values.h"
 
 #if defined(OS_MACOSX)
 #include <mach/mach.h>
 #endif
 
 namespace base {
 
 #if defined(OS_WIN)
 struct IoCounters : public IO_COUNTERS {
 };
@@ skipping 208 matching lines @@
 BASE_EXPORT int GetNumberOfThreads(ProcessHandle process);
 
 // /proc/self/exe refers to the current executable.
 BASE_EXPORT extern const char kProcSelfExe[];
 
 // Data from /proc/meminfo about system-wide memory consumption.
 // Values are in KB.
 struct BASE_EXPORT SystemMemoryInfoKB {
   SystemMemoryInfoKB();
 
+  // Serializes the platform specific fields to value.
+  Value* AsValue() const;

[darin (slow to review), 2013/08/31 03:45:12]

nit: this should return scoped_ptr<Value>

nit: this seems like more of a heavy-weight conversion, so I'd probably go with
ToValue() instead. the "As" prefix works better when an object is a Foo and a
Bar, and you just want to get it *as* one of those.

[jwmak, 2013/09/04 18:49:18]

Done.

+
   int total;
   int free;
   int buffers;
   int cached;
   int active_anon;
   int inactive_anon;
   int active_file;
   int inactive_file;
   int swap_total;
   int swap_free;
@@ skipping 18 matching lines @@
 // Retrieves data from /proc/meminfo and /proc/vmstat
 // about system-wide memory consumption.
 // Fills in the provided |meminfo| structure. Returns true on success.
 // Exposed for memory debugging widget.
 BASE_EXPORT bool GetSystemMemoryInfo(SystemMemoryInfoKB* meminfo);
 
 // Data from /proc/diskstats about system-wide disk I/O.
 struct BASE_EXPORT SystemDiskInfo {
   SystemDiskInfo();
 
+  // Serializes the platform specific fields to value.
+  Value* AsValue() const;

[darin (slow to review), 2013/08/31 03:45:12]

ditto, same nits.

[jwmak, 2013/09/04 18:49:18]

Done.

+
   uint64 reads;
   uint64 reads_merged;
   uint64 sectors_read;
   uint64 read_time;
   uint64 writes;
   uint64 writes_merged;
   uint64 sectors_written;
   uint64 write_time;
   uint64 io;
   uint64 io_time;
@@ skipping 14 matching lines @@
 // Data from files in directory /sys/block/zram0 about ZRAM usage.
 struct BASE_EXPORT SwapInfo {
   SwapInfo()
       : num_reads(0),
         num_writes(0),
         compr_data_size(0),
         orig_data_size(0),
         mem_used_total(0) {
   }
 
+  // Serializes the platform specific fields to value.
+  Value* AsValue() const;
+
   uint64 num_reads;
   uint64 num_writes;
   uint64 compr_data_size;
   uint64 orig_data_size;
   uint64 mem_used_total;
 };
 
 // In ChromeOS, reads files from /sys/block/zram0 that contain ZRAM usage data.
 // Fills in the provided |swap_data| structure.
 BASE_EXPORT void GetSwapInfo(SwapInfo* swap_info);
 #endif  // defined(OS_CHROMEOS)
 
 // Collects and holds performance metrics for system memory and disk.
 // Provides functionality to retrieve the data on various platforms and
 // to serialize the stored data.
 class SystemMetrics {
  public:
   SystemMetrics() : committed_memory_(0) { }
 
   static SystemMetrics Sample();
 
+  // Serializes the system metrics to value.
+  Value* AsValue() const;
+
  private:
   FRIEND_TEST_ALL_PREFIXES(SystemMetricsTest, SystemMetrics);
 
   size_t committed_memory_;
 #if defined(OS_LINUX) || defined(OS_ANDROID)
   SystemMemoryInfoKB memory_info_;
 #endif
 #if defined(OS_LINUX)
   SystemDiskInfo disk_info_;
 #endif
 #if defined(OS_CHROMEOS)
   SwapInfo swap_info_;
 #endif
 };
 
 }  // namespace base
 
 #endif  // BASE_PROCESS_PROCESS_METRICS_H_