Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2315483002: Reduce the log level of frequently occuring DVLOGs (Closed)

Created:
4 years, 3 months ago by hta - Chromium
Modified:
4 years, 3 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce the log level of frequently occuring DVLOGs This changes the most verbose log statements in Mojo from DVLOG(2) to DVLOG(4) (see bug for counts). This should make DVLOG(3) statements useful again. BUG=644088 Committed: https://crrev.com/080b6919d7c585a8d407255c8cb40efdc39eaf9e Cr-Commit-Position: refs/heads/master@{#416667}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M mojo/edk/system/message_pipe_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/ports/node.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
hta - Chromium
This review is a bit out of the blue. Hope it's still useful!
4 years, 3 months ago (2016-09-05 12:00:12 UTC) #5
Ben Goodger (Google)
-me,+ken
4 years, 3 months ago (2016-09-06 16:37:41 UTC) #10
Ken Rockot(use gerrit already)
lgtm
4 years, 3 months ago (2016-09-06 16:40:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315483002/1
4 years, 3 months ago (2016-09-06 16:42:31 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 18:05:57 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 18:08:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/080b6919d7c585a8d407255c8cb40efdc39eaf9e
Cr-Commit-Position: refs/heads/master@{#416667}

Powered by Google App Engine
This is Rietveld 408576698