Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2315473002: Revert of [regexp] Port RegExpExec (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port RegExpExec (patchset #2 id:20001 of https://codereview.chromium.org/2307853002/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Port RegExpExec > > BUG=v8:5339 > > Committed: https://crrev.com/c79e163ba82f2e2dcf9b60639127d187fdbf54b9 > Cr-Commit-Position: refs/heads/master@{#39150} TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5339 Committed: https://crrev.com/76d9e0debaabc2d329a4ad47d009bc4c139fa491 Cr-Commit-Position: refs/heads/master@{#39160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -147 lines) Patch
M src/bootstrapper.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins-regexp.cc View 3 chunks +3 lines, -136 lines 0 comments Download
M src/heap-symbols.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/js/regexp.js View 4 chunks +48 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
jgruber
Created Revert of [regexp] Port RegExpExec
4 years, 3 months ago (2016-09-05 11:52:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315473002/1
4 years, 3 months ago (2016-09-05 11:52:48 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:52:58 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:53:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76d9e0debaabc2d329a4ad47d009bc4c139fa491
Cr-Commit-Position: refs/heads/master@{#39160}

Powered by Google App Engine
This is Rietveld 408576698