Issue 2315363003: [chromedriver] Ensure GetLog works even if the current tab is closed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2315363003: [chromedriver] Ensure GetLog works even if the current tab is closed. (Closed)

Created:
4 years, 3 months ago by samuong

Modified:
4 years, 3 months ago

Reviewers:
stgao

CC:
chromium-reviews, samuong+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[chromedriver] Ensure GetLog works even if the current tab is closed. BUG=chromedriver:1497 TBR=stgao@chromium.org Committed: https://crrev.com/214983ef4fda427d96e275273f53c1c982522635 Cr-Commit-Position: refs/heads/master@{#417128}

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -15 lines)			Patch
	M	chrome/test/chromedriver/session_commands.cc	View	1	2 chunks	+20 lines, -15 lines	0 comments	Download
	M	chrome/test/chromedriver/test/run_py_tests.py	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315363003/20001

4 years, 3 months ago (2016-09-07 23:14:57 UTC) #2

commit-bot: I haz the power

4 years, 3 months ago (2016-09-08 00:20:04 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/214983ef4fda427d96e275273f53c1c982522635
Cr-Commit-Position: refs/heads/master@{#417128}