Record Timeline to Android Systrace

runtime/vm/timeline_test.cc

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <cstring>
 
 #include "platform/assert.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_api_state.h"
@@ skipping 157 matching lines @@
     EXPECT_SUBSTRING("\"ph\":\"X\"", js.ToCString());
     // Check that ts key is present.
     EXPECT_SUBSTRING("\"ts\":", js.ToCString());
     // Check that dur key is present.
     EXPECT_SUBSTRING("\"dur\":", js.ToCString());
   }
   event.DurationEnd();
 }
 
 
+TEST_CASE(TimelineEventPrintSystrace) {
+  const intptr_t kBufferLength = 1024;
+  char buffer[kBufferLength];
+
+  // Create a test stream.
+  TimelineStream stream;
+  stream.Init("testStream", true);
+
+  // Create a test event.
+  TimelineEvent event;
+  TimelineTestHelper::SetStream(&event, &stream);
+
+  // Test a Begin event.
+  event.Begin("apple", 1, 2);
+  event.PrintSystrace(&buffer[0], kBufferLength);
+  EXPECT_SUBSTRING("|apple", buffer);
+  EXPECT_SUBSTRING("B|", buffer);
+
+  // Test an End event.
+  event.End("apple", 2, 3);
+  event.PrintSystrace(&buffer[0], kBufferLength);
+  EXPECT_STREQ("E", buffer);
+
+  // Test a Counter event. We only report the first counter value (in this case
+  // "4").
+  event.Counter("CTR", 1);
+  // We have two counters.
+  event.SetNumArguments(2);
+  // Set the first counter value.
+  event.CopyArgument(0, "cats", "4");
+  // Set the second counter value.
+  event.CopyArgument(1, "dogs", "1");
+  event.PrintSystrace(&buffer[0], kBufferLength);
+  EXPECT_SUBSTRING("C|", buffer);
+  EXPECT_SUBSTRING("|CTR|4", buffer);
+
+  // Test a duration event. This event kind is not supported so we should

[rmacnak, 2016/09/08 18:17:09]

Most of our events are durations, maybe we should emit a begin/end pair to
systrace?

[Cutch, 2016/09/08 18:24:08]

Chinmay and I discussed this and we've decided to wait and see.

+  // serialize it to an empty string.
+  event.Duration("DUR", 0, 1, 2, 3);
+  event.PrintSystrace(&buffer[0], kBufferLength);
+  EXPECT_STREQ("", buffer);
+}
+
+
 TEST_CASE(TimelineEventArguments) {
   // Create a test stream.
   TimelineStream stream;
   stream.Init("testStream", true);
 
   // Create a test event.
   TimelineEvent event;
   TimelineTestHelper::SetStream(&event, &stream);
 
   // Allocate room for four arguments.
@@ skipping 664 matching lines @@
     pauses.Setup();
     pauses.CalculatePauseTimesForThread(tid);
     EXPECT(pauses.has_error());
   }
   TimelineTestHelper::Clear(recorder);
 }
 
 #endif  // !PRODUCT
 
 }  // namespace dart