src/builtins/builtins.h - Issue 2315343002: [builtins] Move StringNormalize to a cpp builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins.h

Issue 2315343002: [builtins] Move StringNormalize to a cpp builtin. (Closed)

Patch Set: fix up some comments and var naming Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins.h

diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h

index 8be259938d23b50c550091e47c7b2f93ff2c0957..db1afedc50afc8e7dcb8c5f3eec579d9a0b26d12 100644

--- a/src/builtins/builtins.h

+++ b/src/builtins/builtins.h

@@ -534,6 +534,8 @@ namespace internal {

TFJ(StringPrototypeCharAt, 2) \

/* ES6 section 21.1.3.2 String.prototype.charCodeAt ( pos ) */ \

TFJ(StringPrototypeCharCodeAt, 2) \

+ /* ECMA-262 v6, section 21.1.3.12 String.prototype.normalize ( [form] ) */ \

Benedikt Meurer 2016/09/09 16:36:06 Nit: for consistency use /* ES6 section ... */

+ CPP(StringPrototypeNormalize) \

/* ES6 section 21.1.3.25 String.prototype.toString () */ \

TFJ(StringPrototypeToString, 1) \

CPP(StringPrototypeTrim) \

« no previous file with comments | « src/bootstrapper.cc ('k') | src/builtins/builtins-string.cc » ('j') | no next file with comments »