[builtins] Move StringNormalize to a cpp builtin.

src/builtins/builtins-string.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/builtins/builtins.h"
 #include "src/builtins/builtins-utils.h"
 
 #include "src/code-factory.h"
 
 namespace v8 {
@@ skipping 459 matching lines @@
     assembler->Return(assembler->NaNConstant());
     assembler->Bind(&if_positioninbounds);
   }
 
   // Load the character at the {position} from the {receiver}.
   Node* value = assembler->StringCharCodeAt(receiver, position);
   Node* result = assembler->SmiFromWord32(value);
   assembler->Return(result);
 }
 
+// ECMA-262 v6, section 21.1.3.12 String.prototype.normalize ( [form] )
+//
+// For now we do nothing, as proper normalization requires big tables.
+// If Intl is enabled, then i18n.js will override it and provide the the
+// proper functionality.
+BUILTIN(StringPrototypeNormalize) {
+  HandleScope handle_scope(isolate);
+  TO_THIS_STRING(string, "String.prototype.trim");

[Franzi, 2016/09/09 12:51:04]

trim?

+
+  Handle<String> form;
+
+  if (args.atOrUndefined(isolate, 1)->IsUndefined(isolate)) {
+    return *string;
+  }
+  MaybeHandle<String> maybe_form(Object::ToString(isolate, args.at<Object>(1)));

[Benedikt Meurer, 2016/09/08 04:41:30]

This is not correct, as the ToString can throw and thus the MaybeHandle may be
null, and form would also be null then. You need to use soemthing along the
lines of

Handle<Object> form = args.atOrUndefined(isolate, 1);
if (form->IsUndefined(isolate)) return *string;
Handle<String> form_string;
ASSIGN_RETURN_FAILURE_ON_EXCEPTION(isolate, form_string,
Object::ToString(isolate, form));

[petermarshall, 2016/09/09 11:41:07]

Done.

+  maybe_form.ToHandle(&form);
+
+  if (!(form->Equals(*isolate->factory()->NewStringFromStaticChars("NFC")) ||
+        form->Equals(*isolate->factory()->NewStringFromStaticChars("NFD")) ||
+        form->Equals(*isolate->factory()->NewStringFromStaticChars("NFKC")) ||
+        form->Equals(*isolate->factory()->NewStringFromStaticChars("NFKD")))) {
+    Handle<String> validForms =
+        isolate->factory()->NewStringFromStaticChars("NFC, NFD, NFKC, NFKD");
+    THROW_NEW_ERROR_RETURN_FAILURE(
+        isolate,
+        NewRangeError(MessageTemplate::kNormalizationForm, validForms));
+  }
+
+  return *string;
+}
+
 // ES6 section 21.1.3.25 String.prototype.toString ()
 void Builtins::Generate_StringPrototypeToString(CodeStubAssembler* assembler) {
   typedef compiler::Node Node;
 
   Node* receiver = assembler->Parameter(0);
   Node* context = assembler->Parameter(3);
 
   Node* result = assembler->ToThisValue(
       context, receiver, PrimitiveType::kString, "String.prototype.toString");
   assembler->Return(result);
@@ skipping 27 matching lines @@
   Node* receiver = assembler->Parameter(0);
   Node* context = assembler->Parameter(3);
 
   Node* result = assembler->ToThisValue(
       context, receiver, PrimitiveType::kString, "String.prototype.valueOf");
   assembler->Return(result);
 }
 
 }  // namespace internal
 }  // namespace v8