Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: src/bootstrapper.cc

Issue 2315343002: [builtins] Move StringNormalize to a cpp builtin. (Closed)
Patch Set: Fix crash caused by ToString on unassigned var Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 1377 matching lines...) Expand 10 before | Expand all | Expand 10 after
1388 1388
1389 // Install the "constructor" property on the {prototype}. 1389 // Install the "constructor" property on the {prototype}.
1390 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun, 1390 JSObject::AddProperty(prototype, factory->constructor_string(), string_fun,
1391 DONT_ENUM); 1391 DONT_ENUM);
1392 1392
1393 // Install the String.prototype methods. 1393 // Install the String.prototype methods.
1394 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt, 1394 SimpleInstallFunction(prototype, "charAt", Builtins::kStringPrototypeCharAt,
1395 1, true); 1395 1, true);
1396 SimpleInstallFunction(prototype, "charCodeAt", 1396 SimpleInstallFunction(prototype, "charCodeAt",
1397 Builtins::kStringPrototypeCharCodeAt, 1, true); 1397 Builtins::kStringPrototypeCharCodeAt, 1, true);
1398 SimpleInstallFunction(prototype, "normalize",
1399 Builtins::kStringPrototypeNormalize, 0, false);
1398 SimpleInstallFunction(prototype, "toString", 1400 SimpleInstallFunction(prototype, "toString",
1399 Builtins::kStringPrototypeToString, 0, true); 1401 Builtins::kStringPrototypeToString, 0, true);
1400 SimpleInstallFunction(prototype, "trim", Builtins::kStringPrototypeTrim, 0, 1402 SimpleInstallFunction(prototype, "trim", Builtins::kStringPrototypeTrim, 0,
1401 false); 1403 false);
1402 SimpleInstallFunction(prototype, "trimLeft", 1404 SimpleInstallFunction(prototype, "trimLeft",
1403 Builtins::kStringPrototypeTrimLeft, 0, false); 1405 Builtins::kStringPrototypeTrimLeft, 0, false);
1404 SimpleInstallFunction(prototype, "trimRight", 1406 SimpleInstallFunction(prototype, "trimRight",
1405 Builtins::kStringPrototypeTrimRight, 0, false); 1407 Builtins::kStringPrototypeTrimRight, 0, false);
1406 SimpleInstallFunction(prototype, "valueOf", 1408 SimpleInstallFunction(prototype, "valueOf",
1407 Builtins::kStringPrototypeValueOf, 0, true); 1409 Builtins::kStringPrototypeValueOf, 0, true);
(...skipping 2745 matching lines...) Expand 10 before | Expand all | Expand 10 after
4153 } 4155 }
4154 4156
4155 4157
4156 // Called when the top-level V8 mutex is destroyed. 4158 // Called when the top-level V8 mutex is destroyed.
4157 void Bootstrapper::FreeThreadResources() { 4159 void Bootstrapper::FreeThreadResources() {
4158 DCHECK(!IsActive()); 4160 DCHECK(!IsActive());
4159 } 4161 }
4160 4162
4161 } // namespace internal 4163 } // namespace internal
4162 } // namespace v8 4164 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/builtins/builtins.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698