Add a base class of Texture for interfacing with the mailbox manager.

Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5a3b3eea85250012dfa753b5223af6ba292256a0
Cr-Commit-Position: refs/heads/master@{#417046}

[Geoff Lang, 2016-09-07 14:18:31]

Description was changed from

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

patch from issue 2232863003 at patchset 40001
(http://crrev.com/2232863003#ps40001)
==========

to

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Geoff Lang, 2016-09-07 14:18:36]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-09-07 14:53:06]

geofflang@chromium.org changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[Geoff Lang, 2016-09-07 14:53:07]

PTAL, let me know what you think of tackling the issue this way.  I think it's
the least intrusive way of removing the state tracking in Textures while
maintaining support in the current command buffer.

[commit-bot: I haz the power, 2016-09-07 15:48:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:48:34]

Dry run: This issue passed the CQ dry run.

[piman, 2016-09-07 17:38:31]

This sounds fine in principle. A couple of issues.

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/mailbox_manager_sync.cc (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/mailbox_manager_sync.cc:194: TextureBase*
MailboxManagerSync::ConsumeTexture(const Mailbox& mailbox) {
nit: you can use covariant returns and return Texture here.

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:360: DCHECK_EQ(nullptr,
mailbox_manager_);
nit: use chromium style for indents and {} below ('git cl format' is your
friend)

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.h:54: virtual Texture* AsTexture();
Will we ever use more than one derived type in a given MailboxManager? If not,
this is unnecessary and could be replaced with static casts.

[Geoff Lang, 2016-09-07 18:13:29]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 18:13:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-09-07 18:14:49]

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/mailbox_manager_sync.cc (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/mailbox_manager_sync.cc:194: TextureBase*
MailboxManagerSync::ConsumeTexture(const Mailbox& mailbox) {
On 2016/09/07 17:38:31, piman wrote:
> nit: you can use covariant returns and return Texture here.

Done.

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:360: DCHECK_EQ(nullptr,
mailbox_manager_);
On 2016/09/07 17:38:31, piman wrote:
> nit: use chromium style for indents and {} below ('git cl format' is your
> friend)

Done.

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.h (right):

https://codereview.chromium.org/2315313003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.h:54: virtual Texture* AsTexture();
On 2016/09/07 17:38:31, piman wrote:
> Will we ever use more than one derived type in a given MailboxManager? If not,
> this is unnecessary and could be replaced with static casts.

No, each mailbox manager will only ever use one kind of texture object.  I can
fall back to static_casts, but I wasn't sure how comfortable you would be with
that more "unsafe" style.

Done.

[piman, 2016-09-07 19:06:58]

LGTM, thanks. I think the static_cast is ok, but maybe worth adding a comment
somewhere to explain why, if you think it's not clear.

[commit-bot: I haz the power, 2016-09-07 19:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 19:36:09]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2016-09-07 21:06:18]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-09-07 21:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 21:37:53]

Description was changed from

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-07 21:37:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-07 21:40:10]

Description was changed from

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add a base class of Texture for interfacing with the mailbox manager.

The basic mailbox manager, MailboxManagerImpl doesn't need the full state
tracking that the Texture class provides and the Passthrough command buffer
will be unable to provide.  MailboxManagerSync will be addressed later but in
the meantime it will downcast TextureBase to Texture.

BUG=602688
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/5a3b3eea85250012dfa753b5223af6ba292256a0
Cr-Commit-Position: refs/heads/master@{#417046}
==========

[commit-bot: I haz the power, 2016-09-07 21:40:11]

Patchset 2 (id:??) landed as
https://crrev.com/5a3b3eea85250012dfa753b5223af6ba292256a0
Cr-Commit-Position: refs/heads/master@{#417046}