Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2315303002: Remove calls to IsRunningSequenceOnCurrentThread() in wallpaper API. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
xdai1, bshe
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to IsRunningSequenceOnCurrentThread() in wallpaper API. SequencedWorkerPool is being migrated to base/task_scheduler and there is no equivalent to IsRunningSequenceOnCurrentThread() in base/task_scheduler. Developers should use SequenceChecker to verify that tasks run sequentially. Unlike SequencedWorkerPool::IsRunningSequenceOnCurrentThread(), SequenceChecker works everywhere in Chrome (MessageLoop, SequencedWorkerPool, base/task_scheduler...). BUG=622400 Committed: https://crrev.com/d78593a22966b10cd96a9a46d86819d7f9b38d4b Cr-Commit-Position: refs/heads/master@{#418560}

Patch Set 1 #

Patch Set 2 : Leaky LazyInstance #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -71 lines) Patch
M chrome/browser/chromeos/extensions/wallpaper_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_api.cc View 3 chunks +6 lines, -6 lines 2 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.h View 7 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 13 chunks +31 lines, -36 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 1 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-07 16:37:31 UTC) #6
fdoray
bshe@: ping +xdai@ in case bshe isn't available
4 years, 3 months ago (2016-09-14 13:26:41 UTC) #10
bshe
lgtm Sorry for the delay https://codereview.chromium.org/2315303002/diff/20001/chrome/browser/chromeos/extensions/wallpaper_api.cc File chrome/browser/chromeos/extensions/wallpaper_api.cc (right): https://codereview.chromium.org/2315303002/diff/20001/chrome/browser/chromeos/extensions/wallpaper_api.cc#newcode13 chrome/browser/chromeos/extensions/wallpaper_api.cc:13: #include "base/logging.h" nit: doesn't ...
4 years, 3 months ago (2016-09-14 13:33:08 UTC) #11
fdoray
https://codereview.chromium.org/2315303002/diff/20001/chrome/browser/chromeos/extensions/wallpaper_api.cc File chrome/browser/chromeos/extensions/wallpaper_api.cc (right): https://codereview.chromium.org/2315303002/diff/20001/chrome/browser/chromeos/extensions/wallpaper_api.cc#newcode13 chrome/browser/chromeos/extensions/wallpaper_api.cc:13: #include "base/logging.h" On 2016/09/14 13:33:07, bshe wrote: > nit: ...
4 years, 3 months ago (2016-09-14 14:04:03 UTC) #12
fdoray
4 years, 3 months ago (2016-09-14 14:04:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315303002/20001
4 years, 3 months ago (2016-09-14 14:04:42 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 14:43:52 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 14:46:03 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d78593a22966b10cd96a9a46d86819d7f9b38d4b
Cr-Commit-Position: refs/heads/master@{#418560}

Powered by Google App Engine
This is Rietveld 408576698