Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2315243002:
views: use MEDIUM for TabbedPane tabs, not NORMAL (Closed)
|
Created:
4 years, 3 months ago by Elly Fong-Jones Modified:
4 years, 3 months ago CC:
chromium-reviews, tfarina Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionviews: use MEDIUM for TabbedPane tabs, not NORMAL
BUG=635176
Committed: https://crrev.com/30699ab305dc5f99307a44b59ecc50c58220e274
Cr-Commit-Position: refs/heads/master@{#416990}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG= ========== to ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG= ==========
ellyjones@chromium.org changed reviewers: + estade@chromium.org
estade: ptal? :)
On 2016/09/07 11:55:56, Elly Jones wrote: > estade: ptal? :) lgtm nit: fill in bug number
Description was changed from ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG= ========== to ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG=635176 ==========
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
ellyjones@chromium.org changed reviewers: + sky@chromium.org
sky: ptal as views owner? :)
LGTM
The CQ bit was checked by ellyjones@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG=635176 ========== to ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG=635176 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG=635176 ========== to ========== views: use MEDIUM for TabbedPane tabs, not NORMAL BUG=635176 Committed: https://crrev.com/30699ab305dc5f99307a44b59ecc50c58220e274 Cr-Commit-Position: refs/heads/master@{#416990} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30699ab305dc5f99307a44b59ecc50c58220e274 Cr-Commit-Position: refs/heads/master@{#416990} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
