third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2315223003: Move didUpdateTextOfFocusedElementByNonUserInput from WebViewClient to WebWidgetClient.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2315223003: Move didUpdateTextOfFocusedElementByNonUserInput from WebViewClient to WebWidgetClient. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index 77ac1c19124dbe6e4332e0726b48b2780d16fffd..ea2f3a29ded909edfb9c8320a0ae9a041beec0ea 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -986,10 +986,10 @@ void ChromeClientImpl::willSetInputMethodState()

m_webView->client()->resetInputMethod();

}

-void ChromeClientImpl::didUpdateTextOfFocusedElementByNonUserInput()

+void ChromeClientImpl::didUpdateTextOfFocusedElementByNonUserInput(LocalFrame& frame)

{

- if (m_webView->client())

- m_webView->client()->didUpdateTextOfFocusedElementByNonUserInput();

+ WebLocalFrameImpl* webFrame = WebLocalFrameImpl::fromFrame(frame.localFrameRoot());

+ webFrame->frameWidget()->client()->didUpdateTextOfFocusedElementByNonUserInput();

}

void ChromeClientImpl::showImeIfNeeded()