Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2315223003: Move didUpdateTextOfFocusedElementByNonUserInput from WebViewClient to WebWidgetClient. (Closed)

Created:
4 years, 3 months ago by lfg
Modified:
4 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, blink-reviews-html_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move didUpdateTextOfFocusedElementByNonUserInput from WebViewClient to WebWidgetClient. This is part of a refactor to split WebView/WebWidget. BUG=583347 Committed: https://crrev.com/1c4ff63fc531d7bbb626329b8e7648ecc4b94b22 Cr-Commit-Position: refs/heads/master@{#417056}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLInputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebViewClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
lfg
Please take a look.
4 years, 3 months ago (2016-09-07 19:29:54 UTC) #5
dcheng
Mehhhhh Android! LGTM
4 years, 3 months ago (2016-09-07 19:47:43 UTC) #8
lfg
+avi for content/.
4 years, 3 months ago (2016-09-07 20:25:24 UTC) #10
Avi (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-07 20:32:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315223003/1
4 years, 3 months ago (2016-09-07 20:39:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:47:12 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:50:30 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c4ff63fc531d7bbb626329b8e7648ecc4b94b22
Cr-Commit-Position: refs/heads/master@{#417056}

Powered by Google App Engine
This is Rietveld 408576698