Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/http/http_network_session.cc

Issue 2315213002: Temporary: Detect WebSocket destruction order problem (Closed)
Patch Set: s/October 2017/October 2016/ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_network_session.h ('k') | net/websockets/websocket_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_session.cc
diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc
index b7993218f215447b3eb4d660bc8d6e635e0826c7..e2f6ae546fd5834db2d8efc4f8217b7a9eda0525 100644
--- a/net/http/http_network_session.cc
+++ b/net/http/http_network_session.cc
@@ -256,6 +256,9 @@ HttpNetworkSession::HttpNetworkSession(const Params& params)
HttpNetworkSession::~HttpNetworkSession() {
base::STLDeleteElements(&response_drainers_);
spdy_session_pool_.CloseAllSessions();
+
+ // TODO(ricea): Remove this by October 2016. See bug 641013.
+ CHECK_EQ(active_websockets_, 0);
}
void HttpNetworkSession::AddResponseDrainer(HttpResponseBodyDrainer* drainer) {
« no previous file with comments | « net/http/http_network_session.h ('k') | net/websockets/websocket_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698