Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 231513004: rebaseline_server: eliminate meaningless 404 errors while waiting for content to load (Closed)

Created:
6 years, 8 months ago by epoger
Modified:
6 years, 8 months ago
Reviewers:
jcgregorio
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: eliminate meaningless 404 errors while waiting for content to load (SkipBuildbotRuns) NOTREECHECKS=True NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14138

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gm/rebaseline_server/static/view.html View 4 chunks +4 lines, -4 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
epoger
PTAL https://codereview.chromium.org/231513004/diff/1/gm/rebaseline_server/static/view.html File gm/rebaseline_server/static/view.html (right): https://codereview.chromium.org/231513004/diff/1/gm/rebaseline_server/static/view.html#newcode348 gm/rebaseline_server/static/view.html:348: ng-src="{{imageSets[constants.KEY__IMAGESETS__SET__IMAGE_A][constants.KEY__IMAGESETS__FIELD__BASE_URL]}}/{{imagePair[constants.KEY__IMAGE_A_URL]}}" /> See http://stackoverflow.com/questions/12922509/image-get-requests-with-angularjs
6 years, 8 months ago (2014-04-10 20:39:26 UTC) #1
jcgregorio
On 2014/04/10 20:39:26, epoger wrote: > PTAL > > https://codereview.chromium.org/231513004/diff/1/gm/rebaseline_server/static/view.html > File gm/rebaseline_server/static/view.html (right): > ...
6 years, 8 months ago (2014-04-10 20:40:54 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 8 months ago (2014-04-10 20:41:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/231513004/1
6 years, 8 months ago (2014-04-10 20:41:07 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 20:41:15 UTC) #5
Message was sent while issue was closed.
Change committed as 14138

Powered by Google App Engine
This is Rietveld 408576698