Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: bench/gen_bench_expectations.py

Issue 231513002: Adjusts the bench expectations calculation to consider average value. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_expectations.py
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index 57f61c9fa78a58ca90714f9681dc8fdedf8ebd4b..4212c0e05b44538e37bd75b6d5e94f0a4ea2e220 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -13,7 +13,7 @@ import sys
# Parameters for calculating bench ranges.
RANGE_RATIO = 1.0 # Ratio of range for upper and lower bounds.
-ABS_ERR = 1.0 # Additional allowed error in milliseconds.
+ERR_RATIO = 0.05 # Further widens the range by the ratio of average value.
# List of bench configs to monitor. Ignore all other configs.
CONFIGS_TO_INCLUDE = ['simple_viewport_1000x1000',
@@ -35,9 +35,10 @@ def compute_ranges(benches):
minimum = min(benches)
maximum = max(benches)
diff = maximum - minimum
+ avg = sum(benches) / len(benches)
- return [minimum - diff * RANGE_RATIO - ABS_ERR,
- maximum + diff * RANGE_RATIO + ABS_ERR]
+ return [minimum - diff * RANGE_RATIO - avg * ERR_RATIO,
+ maximum + diff * RANGE_RATIO + avg * ERR_RATIO]
def create_expectations_dict(revision_data_points):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698