MSE: Throw TypeError instead of InvalidAccessError per spec update

third_party/WebKit/Source/modules/mediasource/MediaSource.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 118 matching lines @@
     BLINK_MSLOG << __func__ << " this=" << this;
     DCHECK(isClosed());
 }
 
 void MediaSource::logAndThrowDOMException(ExceptionState& exceptionState, const ExceptionCode& error, const String& message)
 {
     BLINK_MSLOG << __func__ << " (error=" << error << ", message=" << message << ")";
     exceptionState.throwDOMException(error, message);
 }
 
+void MediaSource::logAndThrowTypeError(ExceptionState& exceptionState, const String& message)
+{
+    BLINK_MSLOG << __func__ << " (message=" << message << ")";
+    exceptionState.throwTypeError(message);
+}
+
 SourceBuffer* MediaSource::addSourceBuffer(const String& type, ExceptionState& exceptionState)
 {
     BLINK_MSLOG << __func__ << " this=" << this << " type=" << type;
 
-    // 2.2 https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type
-    // 1. If type is an empty string then throw an InvalidAccessError exception
+    // 2.2 https://www.w3.org/TR/media-source/#widl-MediaSource-addSourceBuffer-SourceBuffer-DOMString-type/
+    // 1. If type is an empty string then throw a TypeError exception
     // and abort these steps.
     if (type.isEmpty()) {
-        logAndThrowDOMException(exceptionState, InvalidAccessError, "The type provided is empty.");
+        logAndThrowTypeError(exceptionState, "The type provided is empty");
         return 0;
     }
 
     // 2. If type contains a MIME type that is not supported ..., then throw a
     // NotSupportedError exception and abort these steps.
     if (!isTypeSupported(type)) {
         logAndThrowDOMException(exceptionState, NotSupportedError, "The type provided ('" + type + "') is unsupported.");
         return 0;
     }
 
@@ skipping 276 matching lines @@
             sourceBuffer->videoTracks().trackSelected(track->id());
         sourceBuffer->videoTracks().scheduleChangeEvent();
     }
 
     bool isActive = (sourceBuffer->videoTracks().selectedIndex() != -1) || sourceBuffer->audioTracks().hasEnabledTrack();
     setSourceBufferActive(sourceBuffer, isActive);
 }
 
 void MediaSource::setDuration(double duration, ExceptionState& exceptionState)
 {
-    // 2.1 http://www.w3.org/TR/media-source/#widl-MediaSource-duration
-    // 1. If the value being set is negative or NaN then throw an InvalidAccessError
+    // 2.1 https://www.w3.org/TR/media-source/#widl-MediaSource-duration
+    // 1. If the value being set is negative or NaN then throw a TypeError
     // exception and abort these steps.
     if (std::isnan(duration)) {
-        logAndThrowDOMException(exceptionState, InvalidAccessError, ExceptionMessages::notAFiniteNumber(duration, "duration"));
+        logAndThrowTypeError(exceptionState, ExceptionMessages::notAFiniteNumber(duration, "duration"));
         return;
     }
     if (duration < 0.0) {
-        logAndThrowDOMException(exceptionState, InvalidAccessError, ExceptionMessages::indexExceedsMinimumBound("duration", duration, 0.0));
+        logAndThrowTypeError(exceptionState, ExceptionMessages::indexExceedsMinimumBound("duration", duration, 0.0));
         return;
     }
 
     // 2. If the readyState attribute is not "open" then throw an InvalidStateError
     // exception and abort these steps.
     // 3. If the updating attribute equals true on any SourceBuffer in sourceBuffers,
     // then throw an InvalidStateError exception and abort these steps.
     if (throwExceptionIfClosedOrUpdating(isOpen(), isUpdating(), exceptionState))
         return;
 
@@ skipping 100 matching lines @@
     // 2. If the updating attribute equals true on any SourceBuffer in
     //    SourceBuffers, then throw an InvalidStateError exception and abort
     //    these steps.
     //    Note: https://github.com/w3c/media-source/issues/118, once fixed, will
     //    remove the updating check (step 2). We skip that check here already.
     if (throwExceptionIfClosed(isOpen(), exceptionState))
         return;
 
     // 3. If start is negative or greater than end, then throw a TypeError
     //    exception and abort these steps.
     if (start < 0 || start > end) {

[chcunningham, 2016/09/07 18:36:05]

Note that we let start == end here. That allolwed by the spec, just calling it
to check that we're ok with this

[wolenetz, 2016/09/07 21:09:26]

This is intended. It allows an app to direct the UA to restrict seeks to exactly
such a time (of course, extended earlier and/or later if the current buffered
ranges start and end are less than this time or greater than this time,
respectively.
Note also that
https://www.w3.org/TR/html51/semantics-embedded-content.html#normalized-timer...
allows a range to exist with start == end.

-        exceptionState.throwTypeError(ExceptionMessages::indexOutsideRange("start value", start, 0.0, ExceptionMessages::InclusiveBound, end, ExceptionMessages::InclusiveBound));
+        logAndThrowTypeError(exceptionState, ExceptionMessages::indexOutsideRange("start value", start, 0.0, ExceptionMessages::InclusiveBound, end, ExceptionMessages::InclusiveBound));
         return;
     }
 
     // 4. Set live seekable range to be a new normalized TimeRanges object
     //    containing a single range whose start position is start and end
     //    position is end.
     m_liveSeekableRange = TimeRanges::create(start, end);
 }
 
 void MediaSource::clearLiveSeekableRange(ExceptionState& exceptionState)
@@ skipping 156 matching lines @@
 
     m_asyncEventQueue->enqueueEvent(event);
 }
 
 URLRegistry& MediaSource::registry() const
 {
     return MediaSourceRegistry::registry();
 }
 
 } // namespace blink