Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2315033002:
[MD settings] sort settings css vars (Closed)
|
Created:
4 years, 3 months ago by dschuyler Modified:
4 years, 3 months ago Reviewers:
stevenjb CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] sort settings css vars
This CL alphabetizes the settings vars by separating the --settings-*
and --paper-* vars.
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/bda6949845a1dd05da0dbafee6ae4c29886f553c
Cr-Commit-Position: refs/heads/master@{#417067}
Patch Set 1 #
Total comments: 2
Patch Set 2 : review changes #Messages
Total messages: 19 (13 generated)
Description was changed from ========== [MD settings] sort settings css vars This CL alphabetizes the settings vars by separating the --settings-* and --paper-* vars. BUG=None ========== to ========== [MD settings] sort settings css vars This CL alphabetizes the settings vars by separating the --settings-* and --paper-* vars. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dschuyler@chromium.org changed reviewers: + stevenjb@chromium.org
Thanks for fixing this, lgtm! https://codereview.chromium.org/2315033002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_vars_css.html (right): https://codereview.chromium.org/2315033002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_vars_css.html:66: height: 36px; sort height width Also, should these be aligned with --, same throughout? I don't feel strongly either way.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
https://codereview.chromium.org/2315033002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/settings_vars_css.html (right): https://codereview.chromium.org/2315033002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/settings_vars_css.html:66: height: 36px; On 2016/09/07 15:45:01, stevenjb wrote: > sort height width Done. > Also, should these be aligned with --, same throughout? I don't feel strongly > either way. I agree that it looks odd with the --, but I think the two space indent with the braces is correct.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2315033002/#ps20001 (title: "review changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [MD settings] sort settings css vars This CL alphabetizes the settings vars by separating the --settings-* and --paper-* vars. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] sort settings css vars This CL alphabetizes the settings vars by separating the --settings-* and --paper-* vars. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bda6949845a1dd05da0dbafee6ae4c29886f553c Cr-Commit-Position: refs/heads/master@{#417067} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/bda6949845a1dd05da0dbafee6ae4c29886f553c Cr-Commit-Position: refs/heads/master@{#417067} |
