Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2315013003: Revert of arc: Fix thread unsafe behavior of ArcDownloadsWatcherService (Closed)

Created:
4 years, 3 months ago by hashimoto
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of arc: Fix thread unsafe behavior of ArcDownloadsWatcherService (patchset #1 id:1 of https://codereview.chromium.org/2313213002/ ) Reason for revert: Syntax error Original issue's description: > arc: Fix thread unsafe behavior of ArcDownloadsWatcherService > > ArcBridgeService is not thread-safe. > WeakPtr should be defererenced only on the thread to which the > factory belongs. > > BUG=643059 > > Review-Url: https://codereview.chromium.org/2304523002 > Cr-Commit-Position: refs/heads/master@{#416194} > (cherry picked from commit 3c74f1cb2742e9b050fbc830f1ac0e06163c2370) > > Committed: https://chromium.googlesource.com/chromium/src/+/8c306683e2476a091d8fd0b94c87a9ecefff87bd TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/chromeos/arc/arc_downloads_watcher_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_downloads_watcher_service.cc View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hashimoto
Created Revert of arc: Fix thread unsafe behavior of ArcDownloadsWatcherService
4 years, 3 months ago (2016-09-07 03:38:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315013003/1
4 years, 3 months ago (2016-09-07 03:38:21 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 03:41:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698