Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2315003002: Remove calls to deprecated MessageLoop methods in ui. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in ui. This CL (hopefully) removes all calls to these methods in ui: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=sky@chromium.org Committed: https://crrev.com/3c948f7a741bcc7b70d6a7114dcb62f176f8b55f Cr-Commit-Position: refs/heads/master@{#417059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M ui/arc/notification/arc_notification_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/base/cocoa/menu_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 21:56:46 UTC) #5
sky
Please bounce these to more local owners. Thanks.
4 years, 3 months ago (2016-09-06 22:29:51 UTC) #6
fdoray
yoshiki@chromium.org: Please review changes in ui/arc/notification avi@chromium.org: Please review changes in ui/base/cocoa
4 years, 3 months ago (2016-09-07 13:33:10 UTC) #8
Avi (use Gerrit)
lgtm stampity stamp
4 years, 3 months ago (2016-09-07 15:48:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2315003002/1
4 years, 3 months ago (2016-09-07 20:19:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 21:50:46 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 21:52:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c948f7a741bcc7b70d6a7114dcb62f176f8b55f
Cr-Commit-Position: refs/heads/master@{#417059}

Powered by Google App Engine
This is Rietveld 408576698