Harmony - manually draw combobox arrows.

Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also improves border drawing at fractional scales.

BUG=635164
Committed: https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1
Cr-Commit-Position: refs/heads/master@{#416793}

[Evan Stade, 2016-09-06 22:03:52]

Description was changed from

==========
Harmony - manually draw combobox arrows.

BUG=635164
==========

to

==========
Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also
improves border drawing at fractional scales.

BUG=635164
==========

[Evan Stade, 2016-09-06 22:03:52]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-09-06 22:04:22]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:05:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 22:37:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 22:37:46]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Evan Stade, 2016-09-06 23:17:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 23:18:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-06 23:20:41]

LGTM

https://codereview.chromium.org/2314983003/diff/40001/ui/views/controls/combo...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2314983003/diff/40001/ui/views/controls/combo...
ui/views/controls/combobox/combobox.cc:439: // A layer is applied to make sure
that canvas bounds are snapped to pixel
ugh!

[Evan Stade, 2016-09-07 00:07:28]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-09-07 00:07:35]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-09-07 00:07:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 00:22:56]

Description was changed from

==========
Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also
improves border drawing at fractional scales.

BUG=635164
==========

to

==========
Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also
improves border drawing at fractional scales.

BUG=635164
==========

[commit-bot: I haz the power, 2016-09-07 00:22:57]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 00:26:40]

Description was changed from

==========
Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also
improves border drawing at fractional scales.

BUG=635164
==========

to

==========
Harmony - manually draw combobox arrows.

This takes care to draw arrows nicely at fractional scale factors. It also
improves border drawing at fractional scales.

BUG=635164

Committed: https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1
Cr-Commit-Position: refs/heads/master@{#416793}
==========

[commit-bot: I haz the power, 2016-09-07 00:26:43]

Patchset 3 (id:??) landed as
https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1
Cr-Commit-Position: refs/heads/master@{#416793}