Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2314983003: Harmony - manually draw combobox arrows. (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmony - manually draw combobox arrows. This takes care to draw arrows nicely at fractional scale factors. It also improves border drawing at fractional scales. BUG=635164 Committed: https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1 Cr-Commit-Position: refs/heads/master@{#416793}

Patch Set 1 #

Patch Set 2 : also do border #

Patch Set 3 : silence windows complaint #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M ui/views/controls/combobox/combobox.cc View 1 2 4 chunks +36 lines, -3 lines 1 comment Download
M ui/views/controls/focusable_border.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Evan Stade
4 years, 3 months ago (2016-09-06 22:04:18 UTC) #3
sky
LGTM https://codereview.chromium.org/2314983003/diff/40001/ui/views/controls/combobox/combobox.cc File ui/views/controls/combobox/combobox.cc (right): https://codereview.chromium.org/2314983003/diff/40001/ui/views/controls/combobox/combobox.cc#newcode439 ui/views/controls/combobox/combobox.cc:439: // A layer is applied to make sure ...
4 years, 3 months ago (2016-09-06 23:20:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314983003/40001
4 years, 3 months ago (2016-09-07 00:07:45 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 00:22:57 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 00:26:43 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/231e59374ebcdb6d76c9ac282ef7989385a3e1b1
Cr-Commit-Position: refs/heads/master@{#416793}

Powered by Google App Engine
This is Rietveld 408576698