Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2314983002: Remove calls to deprecated MessageLoop methods in extensions. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove calls to deprecated MessageLoop methods in extensions. This CL (hopefully) removes all calls to these methods in extensions: - MessageLoop::PostTask - MessageLoop::PostDelayedTask - MessageLoop::DeleteSoon - MessageLoop::ReleaseSoon - MessageLoop::Run - MessageLoop::RunUntilIdle BUG=616447 R=reillyg@chromium.org Committed: https://crrev.com/311b80864193429e1cb49bdf6e78014127bbf89a Cr-Commit-Position: refs/heads/master@{#416758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M extensions/browser/api/audio/audio_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-06 21:56:29 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 3 months ago (2016-09-06 22:10:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314983002/1
4 years, 3 months ago (2016-09-06 22:56:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 23:13:19 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:17:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/311b80864193429e1cb49bdf6e78014127bbf89a
Cr-Commit-Position: refs/heads/master@{#416758}

Powered by Google App Engine
This is Rietveld 408576698