Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 2314953002: bluetooth: web: Blacklist field trial test handles missing config. (Closed)

Created:
4 years, 3 months ago by scheib
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: web: Blacklist field trial test handles missing config. Field trials can be configured for testing by either testing/variations/fieldtrial_testing_config_*.json config files, or by procedurally creating a trial in a test. However, tests must be tolerant of config files not being applied because official shipping builders do not use field trial test configurations. BUG=570121, 643013 Committed: https://crrev.com/b00368426e8e625edcce6c65814ea7ea08a7e841 Cr-Commit-Position: refs/heads/master@{#416725}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M chrome/browser/web_bluetooth_browsertest.cc View 1 1 chunk +20 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
scheib
4 years, 3 months ago (2016-09-06 19:33:13 UTC) #3
Jeffrey Yasskin
lgtm
4 years, 3 months ago (2016-09-06 19:43:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314953002/20001
4 years, 3 months ago (2016-09-06 20:24:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 20:53:36 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 20:55:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b00368426e8e625edcce6c65814ea7ea08a7e841
Cr-Commit-Position: refs/heads/master@{#416725}

Powered by Google App Engine
This is Rietveld 408576698