Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2314933006: [ios] Fixed WebTestWithWebState::LoadHtml flakyness. (Closed)

Created:
4 years, 3 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fixed WebTestWithWebState::LoadHtml flakyness. Polling for PAGE_LOADING loadPhase is flaky because the phase can quickly change to PAGE_LOADED in the same runloop cycle. Use WebStateObserver to wait until navigation is committed instead. BUG=643835 Committed: https://crrev.com/1aae82276243c4daa1f0604dab1adcf279112229 Cr-Commit-Position: refs/heads/master@{#416953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -19 lines) Patch
M ios/web/public/test/web_test_with_web_state.mm View 2 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Eugene But (OOO till 7-30)
This should make our tree happier
4 years, 3 months ago (2016-09-07 04:45:16 UTC) #4
Eugene But (OOO till 7-30)
4 years, 3 months ago (2016-09-07 15:56:37 UTC) #8
Jackie Quinn
lgtm!
4 years, 3 months ago (2016-09-07 16:15:05 UTC) #9
Eugene But (OOO till 7-30)
Thanks for a quick review!
4 years, 3 months ago (2016-09-07 16:16:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314933006/1
4 years, 3 months ago (2016-09-07 16:17:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:21:42 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:23:50 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aae82276243c4daa1f0604dab1adcf279112229
Cr-Commit-Position: refs/heads/master@{#416953}

Powered by Google App Engine
This is Rietveld 408576698