Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Rebased past the big reformat. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/resources/rename-common.js » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html
new file mode 100644
index 0000000000000000000000000000000000000000..67d85450a393cad2479256e1f24a8d57a9012aa5
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html
@@ -0,0 +1,120 @@
+<!DOCTYPE html>
+<title>IndexedDB: object store renaming support in aborted transactions</title>
+<script src='../../resources/testharness.js'></script>
+<link rel="help"
+ href="https://w3c.github.io/IndexedDB/#dom-idbobjectstore-name">
+<link rel="author" href="pwnall@chromium.org" title="Victor Costan">
+<script src='../../resources/testharnessreport.js'></script>
+<script src='resources/rename-common.js'></script>
+<script>
+
+promise_test(testCase => {
+ const dbName = databaseName(testCase);
+ let bookStore = null, bookStore2 = null;
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ bookStore = transaction.objectStore('books');
+ bookStore.name = 'renamed_books';
+
+ transaction.abort();
+
+ assert_equals(
+ bookStore.name, 'books',
+ 'IDBObjectStore.name should not reflect the rename any more ' +
+ 'immediately after transaction.abort() returns');
+ assert_array_equals(
+ database.objectStoreNames, ['books'],
+ 'IDBDatabase.objectStoreNames should not reflect the rename ' +
+ 'any more immediately after transaction.abort() returns');
+ assert_array_equals(
+ transaction.objectStoreNames, ['books'],
+ 'IDBTransaction.objectStoreNames should not reflect the ' +
+ 'rename any more immediately after transaction.abort() returns');
+ })).then(event => {
+ assert_equals(bookStore.name, 'books',
+ 'IDBObjectStore.name should not reflect the rename any more ' +
+ 'after the versionchange transaction is aborted');
+ const request = indexedDB.open(dbName, 1);
+ return requestWatcher(testCase, request).wait_for('success');
+ }).then(event => {
+ const database = event.target.result;
+ assert_array_equals(
+ database.objectStoreNames, ['books'],
+ 'IDBDatabase.objectStoreNames should not reflect the rename ' +
+ 'after the versionchange transaction is aborted');
+
+ const transaction = database.transaction('books', 'readonly');
+ bookStore2 = transaction.objectStore('books');
+ return checkStoreContents(
+ testCase, bookStore2,
+ 'Aborting an object store rename transaction should not change ' +
+ "the store's records").then(() => database.close());
+ }).then(() => {
+ assert_equals(
+ bookStore.name, 'books',
+ 'IDBObjectStore used in aborted rename transaction should not ' +
+ 'reflect the rename after the transaction is aborted');
+ assert_equals(
+ bookStore2.name, 'books',
+ 'IDBObjectStore obtained after an aborted rename transaction ' +
+ 'should not reflect the rename');
+ });
+}, 'IndexedDB object store rename in aborted transaction');
+
+promise_test(testCase => {
+ const dbName = databaseName(testCase);
+ let notBookStore = null;
+ return createDatabase(testCase, (database, transaction) => {
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ notBookStore = createNotBooksStore(testCase, database);
+ notBookStore.name = 'not_books_renamed';
+ notBookStore.name = 'not_books_renamed_again';
+
+ transaction.abort();
+
+ assert_equals(
+ notBookStore.name, 'not_books_renamed_again',
+ 'IDBObjectStore.name should reflect the last rename ' +
+ 'immediately after transaction.abort() returns');
+ assert_array_equals(
+ database.objectStoreNames, [],
+ 'IDBDatabase.objectStoreNames should not reflect the creation ' +
+ 'or the rename any more immediately after transaction.abort() ' +
+ 'returns');
+ assert_array_equals(
+ transaction.objectStoreNames, [],
+ 'IDBTransaction.objectStoreNames should not reflect the ' +
+ 'creation or the rename any more immediately after ' +
+ 'transaction.abort() returns');
+ assert_array_equals(notBookStore.indexNames, [],
+ 'IDBObjectStore.indexNames for the newly created store ' +
+ 'should be empty immediately after transaction.abort() ' +
+ 'returns');
+ })).then(event => {
+ assert_equals(
+ notBookStore.name, 'not_books_renamed_again',
+ 'IDBObjectStore.name should reflect the last rename after the ' +
+ 'versionchange transaction is aborted');
+ assert_array_equals(notBookStore.indexNames, [],
+ 'IDBObjectStore.indexNames for the newly created store ' +
+ 'should be empty after the versionchange transaction is aborted ' +
+ 'returns');
+ const request = indexedDB.open(dbName, 1);
+ return requestWatcher(testCase, request).wait_for('success');
+ }).then(event => {
+ const database = event.target.result;
+ assert_array_equals(
+ database.objectStoreNames, [],
+ 'IDBDatabase.objectStoreNames should not reflect the creation or ' +
+ 'the rename after the versionchange transaction is aborted');
+
+ database.close();
+ });
+}, 'IndexedDB object store creation and rename in an aborted transaction');
+
+</script>
« no previous file with comments | « third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html ('k') | third_party/WebKit/LayoutTests/storage/indexeddb/resources/rename-common.js » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698