Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Rebased past the big reformat. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html
diff --git a/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html
new file mode 100644
index 0000000000000000000000000000000000000000..b2b4abc4c63ba9f71e8a862a42e4b3025816a218
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/storage/indexeddb/rename-index-abort.html
@@ -0,0 +1,110 @@
+<!DOCTYPE html>
+<title>IndexedDB: index renaming support in aborted transactions</title>
+<script src='../../resources/testharness.js'></script>
+<link rel="help"
+ href="https://w3c.github.io/IndexedDB/#dom-idbindex-name">
+<link rel="author" href="pwnall@chromium.org" title="Victor Costan">
+<script src='../../resources/testharnessreport.js'></script>
+<script src='resources/rename-common.js'></script>
+<script>
+
+promise_test(testCase => {
+ const dbName = databaseName(testCase);
+ let authorIndex = null, authorIndex2 = null;
+ return createDatabase(testCase, (database, transaction) => {
+ createBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ const store = transaction.objectStore('books');
+ authorIndex = store.index('by_author');
+ authorIndex.name = 'renamed_by_author';
+
+ transaction.abort();
+
+ assert_equals(
+ authorIndex.name, 'by_author',
+ 'IDBIndex.name should not reflect the rename any more ' +
+ 'immediately after transaction.abort() returns');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'IDBObjectStore.indexNames should not reflect the rename any ' +
+ 'more immediately after transaction.abort() returns');
+ })).then(event => {
+ assert_equals(
+ authorIndex.name, 'by_author',
+ 'IDBIndex.name should not reflect the rename any more after the ' +
+ 'versionchange transaction is aborted');
+
+ const request = indexedDB.open(dbName, 1);
+ return requestWatcher(testCase, request).wait_for('success');
+ }).then(event => {
+ const database = event.target.result;
+ const transaction = database.transaction('books', 'readonly');
+ const store = transaction.objectStore('books');
+ assert_array_equals(
+ store.indexNames, ['by_author', 'by_title'],
+ 'IDBDatabase.objectStoreNames should not reflect the rename ' +
+ 'after the versionchange transaction is aborted');
+
+ authorIndex2 = store.index('by_author');
+ return checkAuthorIndexContents(
+ testCase, authorIndex2,
+ 'Aborting an index rename transaction should not change the ' +
+ "index's records").then(() => database.close());
+ }).then(() => {
+ assert_equals(
+ authorIndex.name, 'by_author',
+ 'IDBIndex used in aborted rename transaction should not reflect ' +
+ 'the rename after the transaction is aborted');
+ assert_equals(authorIndex2.name, 'by_author',
+ 'IDBIndex obtained after an aborted rename transaction should ' +
+ 'not reflect the rename');
+ });
+}, 'IndexedDB index rename in aborted transaction');
+
+promise_test(testCase => {
+ const dbName = databaseName(testCase);
+ let authorIndex = null;
+ return createDatabase(testCase, (database, transaction) => {
+ createNotBooksStore(testCase, database);
+ }).then(database => {
+ database.close();
+ }).then(() => migrateDatabase(testCase, 2, (database, transaction) => {
+ const store = transaction.objectStore('not_books');
+ authorIndex = store.createIndex('by_author', 'author');
+ authorIndex.name = 'by_author_renamed';
+ authorIndex.name = 'by_author_renamed_again';
+
+ transaction.abort();
+
+ assert_equals(
+ authorIndex.name, 'by_author_renamed_again',
+ 'IDBIndex.name should reflect the last rename immediately after ' +
+ 'transaction.abort() returns');
+ assert_array_equals(
+ store.indexNames, ['not_by_author', 'not_by_title'],
+ 'IDBObjectStore.indexNames should not reflect the creation or ' +
+ 'the rename immediately after transaction.abort() returns');
+ })).then(event => {
+ assert_equals(
+ authorIndex.name, 'by_author_renamed_again',
+ 'IDBIndex.name should reflect the last rename after the ' +
+ 'versionchange transaction is aborted');
+
+ const request = indexedDB.open(dbName, 1);
+ return requestWatcher(testCase, request).wait_for('success');
+ }).then(event => {
+ const database = event.target.result;
+ const transaction = database.transaction('not_books', 'readonly');
+ const store = transaction.objectStore('not_books');
+ assert_array_equals(
+ store.indexNames, ['not_by_author', 'not_by_title'],
+ 'IDBDatabase.objectStoreNames should not reflect the creation or ' +
+ 'the rename after the versionchange transaction is aborted');
+
+ database.close();
+ });
+}, 'IndexedDB index creation and rename in an aborted transaction');
+
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/storage/indexeddb/rename-object-store-abort.html » ('j') | third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698