Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Rebased. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
index 4a5d672b23d772a072cff20f414c017eabe56394..1ded65ae75bd40f7d0f6a3a41e645e90de966174 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
@@ -325,7 +325,7 @@ void IDBRequest::onSuccess(PassRefPtr<IDBValue> prpValue)
#if ENABLE(ASSERT)
if (value->primaryKey()) {
- ASSERT(value->keyPath() == effectiveObjectStore(m_source)->metadata().keyPath);
+ DCHECK(value->keyPath() == effectiveObjectStore(m_source)->metadata().own.keyPath);
assertPrimaryKeyValidOrInjectable(m_scriptState.get(), value.get());
}
#endif
@@ -420,7 +420,7 @@ DispatchEventResult IDBRequest::dispatchEventInternal(Event* event)
IDB_TRACE("IDBRequest::dispatchEvent");
if (m_contextStopped || !getExecutionContext())
return DispatchEventResult::CanceledBeforeDispatch;
- ASSERT(m_readyState == PENDING);
+ DCHECK_EQ(m_readyState, PENDING);
ASSERT(m_hasPendingActivity);
ASSERT(m_enqueuedEvents.size());
ASSERT(event->target() == this);

Powered by Google App Engine
This is Rietveld 408576698