Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Add failing tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
index 9e5fa8a27d4d1177dd9e4a241b6f719979a858ce..e3bd4b24d6464e6c9e95d63857aceb9f1b48132b 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
@@ -137,17 +137,12 @@ private:
typedef HeapHashMap<String, Member<IDBObjectStore>> IDBObjectStoreMap;
IDBObjectStoreMap m_objectStoreMap;
- // Used to mark stores created in an aborted upgrade transaction as
- // deleted.
- HeapHashSet<Member<IDBObjectStore>> m_createdObjectStores;
-
- // Used to notify object stores (which are no longer in m_objectStoreMap)
- // when the transaction is finished.
+ // Tracks the stores deleted in this transaction.
+ //
+ // All the other stores modified in this transaction must be in
+ // m_objectStoreMap.
HeapHashSet<Member<IDBObjectStore>> m_deletedObjectStores;
- // Holds stores created, deleted, or used during upgrade transactions to
- // reset metadata in case of abort.
- HeapHashMap<Member<IDBObjectStore>, IDBObjectStoreMetadata> m_objectStoreCleanupMap;
IDBDatabaseMetadata m_previousMetadata;
};

Powered by Google App Engine
This is Rietveld 408576698