Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h

Issue 2314933005: Align IndexedDB metadata rollback on transaction abort to spec. (Closed)
Patch Set: Add failing tests. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
index 8ee6519da8f203f6902bf6ba4a2385450faec8b6..c2c4736bf4cb4983b56aa7c854a53948f21f8311 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.h
@@ -97,11 +97,14 @@ public:
void markDeleted() { m_deleted = true; }
bool isDeleted() const { return m_deleted; }
- void abort();
+ void versionChangeTransactionAborted();
void transactionFinished();
const IDBObjectStoreMetadata& metadata() const { return m_metadata; }
- void setMetadata(const IDBObjectStoreMetadata& metadata) { m_metadata = metadata; }
+ // Rolls back the object store's metadata to a previous version.
+ //
+ // Used when a versionchange transaction is aborted.
+ void rollbackMetadata(const IDBObjectStoreMetadata& previousMetadata);
typedef HeapVector<Member<IDBKey>> IndexKeys;

Powered by Google App Engine
This is Rietveld 408576698