Align IndexedDB metadata rollback on transaction abort to spec.

third_party/WebKit/Source/modules/indexeddb/IDBIndex.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 30 matching lines @@
 namespace blink {
 
 class ExceptionState;
 class IDBObjectStore;
 
 class IDBIndex final : public GarbageCollectedFinalized<IDBIndex>,
                        public ScriptWrappable {
   DEFINE_WRAPPERTYPEINFO();
 
  public:
-  static IDBIndex* create(const IDBIndexMetadata& metadata,
+  static IDBIndex* create(RefPtr<IDBIndexMetadata> metadata,
                           IDBObjectStore* objectStore,
                           IDBTransaction* transaction) {
-    return new IDBIndex(metadata, objectStore, transaction);
+    return new IDBIndex(std::move(metadata), objectStore, transaction);
   }
   ~IDBIndex();
   DECLARE_TRACE();
 
   // Implement the IDL
   const String& name() const { return metadata().name; }
   void setName(const String& name, ExceptionState&);
   IDBObjectStore* objectStore() const { return m_objectStore.get(); }
   ScriptValue keyPath(ScriptState*) const;
   bool unique() const { return metadata().unique; }
@@ skipping 16 matching lines @@
                      ExceptionState&);
   IDBRequest* getKey(ScriptState*, const ScriptValue& key, ExceptionState&);
   IDBRequest* getAllKeys(ScriptState*,
                          const ScriptValue& range,
                          ExceptionState&);
   IDBRequest* getAllKeys(ScriptState*,
                          const ScriptValue& range,
                          uint32_t maxCount,
                          ExceptionState&);
 
-  void markDeleted() { m_deleted = true; }
-  bool isDeleted() const;
+  void markDeleted() {
+    DCHECK(m_transaction->isVersionChange())

[jsbell, 2016/10/06 20:01:31]

This should probably move into .cpp file. (Otherwise I think every compilation
unit that includes this header will end up with a copy of the string, albeit
only in debug builds.)

[pwnall, 2016/10/06 22:15:22]

Isn't that an acceptable tradeoff in return for smaller code size on release?
I'm reasonably sure that the setter (address calculation + load, a single mov on
Intel) will be smaller than a method call (push + jump).

+        << "Index deleted outside versionchange transaction.";
+    m_deleted = true;
+  }
+  bool isDeleted() const { return m_deleted; }
   int64_t id() const { return metadata().id; }
+  void revertMetadata(RefPtr<IDBIndexMetadata> oldMetadata);
 
   // Used internally and by InspectorIndexedDBAgent:
   IDBRequest* openCursor(ScriptState*, IDBKeyRange*, WebIDBCursorDirection);
 
   WebIDBDatabase* backendDB() const;
 
  private:
-  IDBIndex(const IDBIndexMetadata&, IDBObjectStore*, IDBTransaction*);
+  IDBIndex(RefPtr<IDBIndexMetadata>, IDBObjectStore*, IDBTransaction*);
 
-  const IDBIndexMetadata& metadata() const { return m_metadata; }
+  const IDBIndexMetadata& metadata() const { return *m_metadata; }
 
   IDBRequest* getInternal(ScriptState*,
                           const ScriptValue& key,
                           ExceptionState&,
                           bool keyOnly);
   IDBRequest* getAllInternal(ScriptState*,
                              const ScriptValue& range,
                              unsigned long maxCount,
                              ExceptionState&,
                              bool keyOnly);
 
-  IDBIndexMetadata m_metadata;
+  RefPtr<IDBIndexMetadata> m_metadata;
   Member<IDBObjectStore> m_objectStore;
   Member<IDBTransaction> m_transaction;
   bool m_deleted = false;
 };
 
 }  // namespace blink
 
 #endif  // IDBIndex_h