Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2314933004: cc/blimp: Remove the LayerTreeSettings serialization. (Closed)

Created:
4 years, 3 months ago by Khushal
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, cc-bugs_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc/blimp: Remove the LayerTreeSettings serialization. The code is unused, the client always builds the settings locally which is necessary because they are platform/device specific. The eventual plan is to build them on the client using the same code as the RenderWidgetCompositor. The next change will remove the Initialize and Close messages altogether. BUG=577985, 644326 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093 Cr-Commit-Position: refs/heads/master@{#416975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -404 lines) Patch
M blimp/client/core/compositor/blimp_compositor.h View 2 chunks +1 line, -2 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M blimp/client/core/compositor/blimp_compositor_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/proto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M cc/proto/compositor_message_to_impl.proto View 3 chunks +0 lines, -11 lines 0 comments Download
D cc/proto/layer_tree_settings.proto View 1 chunk +0 lines, -71 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 2 chunks +0 lines, -152 lines 0 comments Download
D cc/trees/layer_tree_settings_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
M cc/trees/remote_channel_main.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Khushal
+brian for cc, dtrainor for blimp. Thanks!
4 years, 3 months ago (2016-09-06 22:33:02 UTC) #4
vmpstr
cc lgtm. Thanks!
4 years, 3 months ago (2016-09-06 22:37:06 UTC) #7
Khushal
On 2016/09/06 22:37:06, vmpstr wrote: > cc lgtm. Thanks! Thanks Vlad! :)
4 years, 3 months ago (2016-09-06 22:38:37 UTC) #8
David Trainor- moved to gerrit
blimp/ lgtm
4 years, 3 months ago (2016-09-07 05:09:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314933004/1
4 years, 3 months ago (2016-09-07 17:09:56 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 17:16:32 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:19:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/065a2ac30957724ecc1330beae316087c96b7093
Cr-Commit-Position: refs/heads/master@{#416975}

Powered by Google App Engine
This is Rietveld 408576698