Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analyzer/lib/src/context/context.dart

Issue 2314933003: Issue 27130. Fix applying changes to .analysis_options on save. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/context/context.dart
diff --git a/pkg/analyzer/lib/src/context/context.dart b/pkg/analyzer/lib/src/context/context.dart
index 29308aeb46952afd8a058f53eff2263efe8d5af5..5e42099fac4b86a3fc231cb1a6da8e7de2224c00 100644
--- a/pkg/analyzer/lib/src/context/context.dart
+++ b/pkg/analyzer/lib/src/context/context.dart
@@ -620,9 +620,9 @@ class AnalysisContextImpl implements InternalAnalysisContext {
}
@override
- ApplyChangesStatus applyChanges(ChangeSet changeSet) {
+ void applyChanges(ChangeSet changeSet) {
if (changeSet.isEmpty) {
- return new ApplyChangesStatus(false);
+ return;
}
//
// First, compute the list of sources that have been removed.
@@ -665,11 +665,6 @@ class AnalysisContextImpl implements InternalAnalysisContext {
changeSet.addedSources, changedSources, removedSources);
}
_onSourcesChangedController.add(new SourcesChangedEvent(changeSet));
- return new ApplyChangesStatus(changeSet.addedSources.isNotEmpty ||
- changeSet.changedContents.isNotEmpty ||
- changeSet.deletedSources.isNotEmpty ||
- changedSources.isNotEmpty ||
- removedSources.isNotEmpty);
}
@override
« no previous file with comments | « pkg/analysis_server/test/analysis_server_test.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698